Skip to content

Conversation

BewareMyPower
Copy link
Contributor

Motivation

The Namespace bundle for topic (%s) not served by this instance log does not include the actual bundle info. We can check logs of OwnershipCache to see a bundle's ownership. But it's hard to see if the current topic's bundle is owned by the current broker when the error happens. We have to manually compute the hash code and see which bundle this topic belong to.

long hashCode = Hashing.crc32().hashString(topicName.toString(), StandardCharsets.UTF_8).padToLong();
System.out.println(String.format("0x%x", hashCode));

Modifications

Return the bundle info in checkTopicOwnership as well.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 20, 2025
@BewareMyPower BewareMyPower force-pushed the bewaremypower/improve-bundle-not-served-logs branch from 18a192a to 0472d3d Compare June 20, 2025 01:54
@BewareMyPower BewareMyPower self-assigned this Jun 20, 2025
@BewareMyPower BewareMyPower added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker release/3.0.13 release/4.0.6 release/3.3.8 labels Jun 20, 2025
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (bbc6224) to head (511f274).
Report is 1158 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24434      +/-   ##
============================================
+ Coverage     73.57%   74.28%   +0.71%     
- Complexity    32624    32713      +89     
============================================
  Files          1877     1868       -9     
  Lines        139502   145397    +5895     
  Branches      15299    16636    +1337     
============================================
+ Hits         102638   108011    +5373     
+ Misses        28908    28836      -72     
- Partials       7956     8550     +594     
Flag Coverage Δ
inttests 26.69% <75.00%> (+2.11%) ⬆️
systests 23.41% <50.00%> (-0.92%) ⬇️
unittests 73.77% <100.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ache/pulsar/broker/namespace/NamespaceService.java 73.47% <100.00%> (+1.24%) ⬆️
...rg/apache/pulsar/broker/service/BrokerService.java 83.59% <100.00%> (+2.80%) ⬆️

... and 1084 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BewareMyPower BewareMyPower merged commit 19b4a05 into apache:master Jun 21, 2025
53 checks passed
BewareMyPower added a commit that referenced this pull request Jun 27, 2025
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 30, 2025
…ble (apache#24434)

(cherry picked from commit 19b4a05)
(cherry picked from commit 39500e0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 30, 2025
…ble (apache#24434)

(cherry picked from commit 19b4a05)
(cherry picked from commit 39500e0)
lhotari pushed a commit that referenced this pull request Jul 17, 2025
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 22, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.13 release/3.3.8 release/4.0.6 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants