-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][broker] Improve the log when namespace bundle is not available #24434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BewareMyPower
merged 3 commits into
apache:master
from
BewareMyPower:bewaremypower/improve-bundle-not-served-logs
Jun 21, 2025
Merged
[improve][broker] Improve the log when namespace bundle is not available #24434
BewareMyPower
merged 3 commits into
apache:master
from
BewareMyPower:bewaremypower/improve-bundle-not-served-logs
Jun 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18a192a
to
0472d3d
Compare
Technoboy-
reviewed
Jun 20, 2025
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jun 20, 2025
poorbarcode
approved these changes
Jun 20, 2025
lhotari
reviewed
Jun 20, 2025
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Jun 20, 2025
/pulsarbot run-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24434 +/- ##
============================================
+ Coverage 73.57% 74.28% +0.71%
- Complexity 32624 32713 +89
============================================
Files 1877 1868 -9
Lines 139502 145397 +5895
Branches 15299 16636 +1337
============================================
+ Hits 102638 108011 +5373
+ Misses 28908 28836 -72
- Partials 7956 8550 +594
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2025
…ble (apache#24434) (cherry picked from commit 19b4a05) (cherry picked from commit 39500e0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2025
…ble (apache#24434) (cherry picked from commit 19b4a05) (cherry picked from commit 39500e0)
Technoboy-
pushed a commit
that referenced
this pull request
Jul 17, 2025
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 22, 2025
…ble (apache#24434) (cherry picked from commit 497e91c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…ble (apache#24434) (cherry picked from commit 497e91c)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…ble (apache#24434) (cherry picked from commit 19b4a05)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…ble (apache#24434) (cherry picked from commit 19b4a05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.13
release/3.3.8
release/4.0.6
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
Namespace bundle for topic (%s) not served by this instance
log does not include the actual bundle info. We can check logs ofOwnershipCache
to see a bundle's ownership. But it's hard to see if the current topic's bundle is owned by the current broker when the error happens. We have to manually compute the hash code and see which bundle this topic belong to.Modifications
Return the bundle info in
checkTopicOwnership
as well.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: