[SPARK-49300][CORE][3.5] Fix Hadoop delegation token leak when tokenRenewalInterval is not set. #47823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lInterval is not set.
|
@zhangshuyan0 mind filling the PR description please? https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE |
Already added the description. |
sunchao
approved these changes
Aug 22, 2024
sunchao
pushed a commit
that referenced
this pull request
Aug 22, 2024
…enewalInterval is not set Backport from master. ### What changes were proposed in this pull request? Cancel delegation token once they are used in `getTokenRenewalInterval` ### Why are the changes needed? When `tokenRenewalInterval` is not set, HadoopFSDelegationTokenProvider#getTokenRenewalInterval will fetch some tokens and renew them to get a interval value. https://github.com/apache/spark/blob/dd259b0b27841e6dd7c07f8ca3cc05d275863dd5/core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala#L60-L64 These tokens do not call cancel(), resulting in a large number of existing tokens on HDFS not being cleared in a timely manner, causing additional pressure on the HDFS server. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manual test ### Was this patch authored or co-authored using generative AI tooling? no Closes #47823 from zhangshuyan0/branch-3.5-zsy. Authored-by: zhangshuyan <[email protected]> Signed-off-by: Chao Sun <[email protected]>
|
Merged to branch-3.5, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from master.
What changes were proposed in this pull request?
Cancel delegation token once they are used in
getTokenRenewalIntervalWhy are the changes needed?
When
tokenRenewalIntervalis not set, HadoopFSDelegationTokenProvider#getTokenRenewalInterval will fetch some tokens and renew them to get a interval value.spark/core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
Lines 60 to 64 in dd259b0
These tokens do not call cancel(), resulting in a large number of existing tokens on HDFS not being cleared in a timely manner, causing additional pressure on the HDFS server.
Does this PR introduce any user-facing change?
no
How was this patch tested?
manual test
Was this patch authored or co-authored using generative AI tooling?
no