chore: Add exception to requireCanaryStableServices to disable validation when using the hashicorp/consul plugin
#3339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Published Test Results2 124 tests 2 124 ✅ 2m 50s ⏱️ Results for commit 74cf023. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3339 +/- ##
==========================================
+ Coverage 81.83% 82.86% +1.02%
==========================================
Files 135 135
Lines 20688 16845 -3843
==========================================
- Hits 16931 13959 -2972
+ Misses 2883 2012 -871
Partials 874 874 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 31m 5s ⏱️ For more details on these failures, see this check. Results for commit 74cf023. ♻️ This comment has been updated with latest results. |
requireCanaryStableServices to disable validation when using the hashicorp/consul pluginrequireCanaryStableServices to disable validation when using the hashicorp/consul plugin
28a3cbe to
d0287fd
Compare
25eee48 to
647ca89
Compare
|
Hi @zachaller friendly nudge, if you're able to review this PR for Consul Service Mesh. |
zachaller
reviewed
Feb 12, 2024
| @@ -129,6 +129,80 @@ func TestValidateRolloutStrategyBlueGreen(t *testing.T) { | |||
| assert.Equal(t, ScaleDownLimitLargerThanRevisionLimit, allErrs[1].Detail) | |||
| } | |||
|
|
|||
| func TestValidateRolloutStrategyCanaryMissingServiceNames(t *testing.T) { | |||
There was a problem hiding this comment.
Can we add a few test that use two traffic routers one where both are required to have canary service and one where it one requires it and one does not.
There was a problem hiding this comment.
Added some test cases with multiple routers where one requires the canary services and one or more do not to ensure they error as expected.
…when using the `hashicorp/consul` plugin Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]>
Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]>
- added test cases for exceptions to requiring checks for Canary/Stable services - added test cases for verifying errors when Canary/Stable services are missing Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]>
647ca89 to
06a85d1
Compare
Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]>
59571fb to
36c169b
Compare
- added test cases for exceptions to requiring checks for Canary/Stable services - added test cases for verifying errors when Canary/Stable services are missing Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]>
|
zachaller
approved these changes
Feb 12, 2024
|
Thanks so much for helping with this PR @zachaller |
meeech
pushed a commit
to CircleCI-Public/argo-rollouts
that referenced
this pull request
Feb 10, 2025
…dation when using the `hashicorp/consul` plugin (argoproj#3339) * add exception to `requireCanaryStableServices` to disable validation when using the `hashicorp/consul` plugin Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]> * added HashiCorp to USERS.md Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]> * modified requireCanaryStableServices to reverse logic - added test cases for exceptions to requiring checks for Canary/Stable services - added test cases for verifying errors when Canary/Stable services are missing Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]> * addressed comments and added more test cases Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]> * modified requireCanaryStableServices to reverse logic - added test cases for exceptions to requiring checks for Canary/Stable services - added test cases for verifying errors when Canary/Stable services are missing Co-authored-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Michael Wilkerson <[email protected]> --------- Signed-off-by: Michael Wilkerson <[email protected]> Co-authored-by: Ashwin Venkatesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".