fix: when Rollout has pingpong and stable/canary service defined, only alb traffic management uses pingpong. #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Published Test Results2 163 tests 2 163 ✅ 2m 54s ⏱️ Results for commit b57e6b7. ♻️ This comment has been updated with latest results. |
E2E Tests Published Test Results 4 files 4 suites 3h 25m 22s ⏱️ For more details on these failures, see this check. Results for commit b57e6b7. ♻️ This comment has been updated with latest results. |
…StableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true. Signed-off-by: mayz985 <[email protected]>
Signed-off-by: mayz985 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3628 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 156 156
Lines 17969 17970 +1
=======================================
+ Hits 14423 14424 +1
+ Misses 2634 2632 -2
- Partials 912 914 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: mayz985 <[email protected]>
|
zachaller
approved these changes
Jun 12, 2024
zachaller
pushed a commit
that referenced
this pull request
Jun 13, 2024
…y alb traffic management uses pingpong. (#3628) * fix: when Rollout has pingpong and stable/canary service defined, GetStableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true. Signed-off-by: mayz985 <[email protected]> * fix lint error Signed-off-by: mayz985 <[email protected]> * added e2e Signed-off-by: mayz985 <[email protected]> --------- Signed-off-by: mayz985 <[email protected]>
meeech
pushed a commit
to CircleCI-Public/argo-rollouts
that referenced
this pull request
Feb 10, 2025
…y alb traffic management uses pingpong. (argoproj#3628) * fix: when Rollout has pingpong and stable/canary service defined, GetStableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true. Signed-off-by: mayz985 <[email protected]> * fix lint error Signed-off-by: mayz985 <[email protected]> * added e2e Signed-off-by: mayz985 <[email protected]> --------- Signed-off-by: mayz985 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…StableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".