feat(pipelines): cdk-assets version is configurable #34802
Conversation
Make it possible to configure the version of `cdk-assets` CLI used by the CDK Pipeline. This is only useful for versions of `cdk-assets` *newer*` than `3.3.1`, as older versions have wildcard ranges in their transitive dependencies and may install different versions of packages depending on what is currently available on npmjs.com. The first `cdk-assets` version after `3.3.1` will bundle its dependencies so that the install operation will be deterministic. We recommend you don't use this feature and just leave it at `latest`. The bundling of dependencies of `cdk-assets` will already remove any install failures around the release time of a new SDKv3 version, that used to plague `cdk-assets` in the past.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -411,6 +426,7 @@ export class CodePipeline extends PipelineBase { | |||
| this.dockerCredentials = props.dockerCredentials ?? []; | |||
| this.singlePublisherPerAssetType = !(props.publishAssetsInParallel ?? true); | |||
| this.cliVersion = props.cliVersion ?? preferredCliVersion(); | |||
| this.cdkAssetsCliVersion = props.cdkAssetsCliVersion ?? 'latest'; | |||
There was a problem hiding this comment.
Should we use a similar algorithm to cliVersion i.e. preferredCliVersion?
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Make it possible to configure the version of
cdk-assetsCLI used by the CDK Pipeline.This is only useful for versions of
cdk-assetsnewerthan3.3.1`, as older versions have wildcard ranges in their transitive dependencies and may install different versions of packages depending on what is currently available on npmjs.com.The first
cdk-assetsversion after3.3.1will bundle its dependencies so that the install operation will be deterministic.We recommend you don't use this feature and just leave it at
latest. The bundling of dependencies ofcdk-assetswill already remove any install failures around the release time of a new SDKv3 version, that used to plaguecdk-assetsin the past.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license