Skip to content

feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime #34241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime #34241

wants to merge 11 commits into from
+305 −37

Conversation

pv-rudger
Copy link

@pv-rudger pv-rudger commented Apr 24, 2025 •
edited
Loading

Issue # (if applicable)

Closes #34240.

Reason for this change

Runtime versions using Node.js and Puppeteer confirms that Synthetics runtime syn-nodejs-puppeteer-10.0 is available.

Description of changes

Added syn-nodejs-puppeteer-10.0 as supported runtime.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

I have updated some tests, containing the same runtime with the new version.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pv-rudger
feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime (aws…
c210fbb 
…#34240)

Closes aws#34240.

[Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-10.0` is available.

Added `syn-nodejs-puppeteer-10.0` as supported runtime.

N/A

- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation requested a review from a team April 24, 2025 13:13
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Apr 24, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@ykethan ykethan mentioned this pull request Apr 24, 2025
Open
2 tasks
mazyu36
mazyu36 suggested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
I've added one comment.

@mazyu36
Copy link
Contributor

mazyu36 commented Apr 24, 2025

Also could you add an integ test for 10.0?

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts

Line 104 in 15791d7

const puppeteer91 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_9_1);

@github-actions github-actions bot mentioned this pull request May 1, 2025
Open
@pv-rudger
Update snapshot, with 'yarn integ --update-on-failed --dry-run'
0d442d5 
Could only use with dry-run, because it required access to the actual
environment?

comand used:

yarn integ aws-synthetics/test/integ.canary.js --update-on-failed --dry-run
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 3, 2025 19:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@pv-rudger
Copy link
Author

Also could you add an integ test for 10.0?

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts

Line 104 in 15791d7

const puppeteer91 = createCanaryByRuntimes(Runtime.SYNTHETICS_NODEJS_PUPPETEER_9_1);

@mazyu36 Can you validate if this is done correct?

mazyu36
mazyu36 approved these changes May 4, 2025
View reviewed changes
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@pv-rudger
Copy link
Author

I have fixed the merge conflicts, but it will be difficult to maintain without a review

@pv-rudger
Copy link
Author

Can you review this?

@aws/aws-cdk-core-team

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@georeeve georeeve mentioned this pull request May 27, 2025
Open
1 task
@aemada-aws aemada-aws self-assigned this Jun 3, 2025
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8fd264e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazyu36 mazyu36 mazyu36 approved these changes

@aemada-aws aemada-aws aemada-aws approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@aemada-aws aemada-aws

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-synthetics: support syn-nodejs-puppeteer-10.0 runtime
4 participants
@pv-rudger @mazyu36 @aws-cdk-automation @aemada-aws