chore(ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634) #34639
+203
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Jun 5, 2025
8f21b05 to
be8acfd
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
142d99f to
0b257dd
Compare
0b257dd to
a257b45
Compare
laurelmay
approved these changes
Jun 16, 2025
a257b45 to
4294dcd
Compare
4294dcd to
0ee8344
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Abogical
requested changes
Jul 4, 2025
| @@ -11,7 +11,7 @@ def lambda_handler(event, context): | |||
| lifecycle_event = json.loads(event['Records'][0]['Sns']['Message']) | |||
| instance_id = lifecycle_event.get('EC2InstanceId') | |||
| if not instance_id: | |||
| print('Got event without EC2InstanceId: %s', json.dumps(dict(event, ResponseURL='...'))) | |||
| print('Got event without EC2InstanceId: %s' % json.dumps(dict(event, ResponseURL='...'))) | |||
There was a problem hiding this comment.
Why not use f-strings since we're using python 3.13?
Suggested change
| print('Got event without EC2InstanceId: %s' % json.dumps(dict(event, ResponseURL='...'))) | |
| print(f"Got event without EC2InstanceId: { json.dumps(dict(event, ResponseURL='...')) }") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34634.
Reason for this change
The old Lambda Runtime Python 3.9 is being deprecated
Description of changes
Describe any new or updated permissions being added
None
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license