Skip to content

revert(ec2): support Firehose IDeliveryStream as flow log destination #34665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

ozelalisen
Copy link
Member

Reverts #34596 as it created cyclic dependency which blocks the pipeline for Go

@aws-cdk-automation aws-cdk-automation requested a review from a team June 10, 2025 09:28
@github-actions github-actions bot added the p2 label Jun 10, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@ozelalisen ozelalisen changed the title Revert "feat(ec2): support Firehose IDeliveryStream as flow log destination" revert(ec2): support Firehose IDeliveryStream as flow log destination Jun 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 10, 2025 09:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jun 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ad2de2c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jun 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b77bd0e into main Jun 10, 2025
16 checks passed
@mergify mergify bot deleted the revert-34596-ec2-flowlog-firehose branch June 10, 2025 11:02
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants