-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(synthetics): add support for tag replication for aws synthetics #34830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(synthetics): add support for tag replication for aws synthetics #34830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've added a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@lvthillo Could you please merge the latest main branch? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #34811
Related: aws-cloudformation/cloudformation-coverage-roadmap#1101
Reason for this change
Support for tag propagation to underlying resources (Lambda) for AWS Synthetics.
Description of changes
Add support for
ResourcesToReplicateTags
property (like CF)Describe any new or updated permissions being added
/
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license