Skip to content

feat(synthetics): add support for tag replication for aws synthetics #34830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lvthillo
Copy link

@lvthillo lvthillo commented Jun 26, 2025

Issue # (if applicable)

Closes #34811

Related: aws-cloudformation/cloudformation-coverage-roadmap#1101

Reason for this change

Support for tag propagation to underlying resources (Lambda) for AWS Synthetics.

Description of changes

Add support for ResourcesToReplicateTags property (like CF)

Describe any new or updated permissions being added

/

Description of how you validated changes

  • Added unit test
  • Added integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jun 26, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 26, 2025 17:50
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@lvthillo lvthillo changed the title feat(aws-synthetics): add support for tag replication for aws synthetics feat(synthetics): add support for tag replication for aws synthetics Jun 26, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 26, 2025 17:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2025
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've added a minor comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 28, 2025
@lvthillo lvthillo requested a review from badmintoncryer June 28, 2025 21:30
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@badmintoncryer
Copy link
Contributor

@lvthillo Could you please merge the latest main branch? needs-maintainer-review label would be attached.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c39701d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-synthetics): (Support ResourcesToReplicateTags)
3 participants