Skip to content

fix(autoscaling): add an option to run validation when migrating to launch template #34832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jungseoklee
Copy link
Contributor

@jungseoklee jungseoklee commented Jun 27, 2025

This patch add an option to run validation when migrating to launch template, which checks if UpdatePolicy is specified.

Issue # (if applicable)

Closes #34283.

Reason for this change

To make migration to Launch Template safer.

Description of changes

This change introduces an option flag to check whether or not UpdatePolicy is specified. As enforcing UpdatePolicy, existing EC2 instances based on Launch Configuration are terminated, and new EC2 instances based on Launch Template are launched, which always references IAM instance profile defined by Launch Template.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added an unit test and integration test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jun 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2025 03:54
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@jungseoklee jungseoklee force-pushed the for-autoscaling-lt-update-policy branch from eaacbd7 to a5ec18f Compare June 27, 2025 03:59
@jungseoklee jungseoklee changed the title fix(autoscaling): add an option to run validation when migrating to launch template feat(autoscaling): add an option to run validation when migrating to launch template Jun 27, 2025
…aunch template

This patch add an option to run validation when migrating to launch template, which
checks if UpdatePolicy is specified.
@jungseoklee jungseoklee force-pushed the for-autoscaling-lt-update-policy branch from a5ec18f to 4ae6e8e Compare June 27, 2025 08:19
@jungseoklee jungseoklee changed the title feat(autoscaling): add an option to run validation when migrating to launch template fix(autoscaling): add an option to run validation when migrating to launch template Jun 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 27, 2025 08:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4ae6e8e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 27, 2025
@alvazjor alvazjor self-assigned this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-autoscaling): Build guardrail to prevent availability risk by instance profile deletion/recreation during migration to LT
3 participants