Skip to content

Remove console log in production #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anhkhoakz
Copy link

@anhkhoakz anhkhoakz commented Jul 4, 2025

This pull request focuses on cleaning up unnecessary logging statements in the codebase to streamline the output and improve readability. The changes primarily involve removing console.log statements from several utility functions and the main entry point.

Logging cleanup:

@backwardspy
Copy link
Member

these logs are useful for debugging and i can't imagine they cause enough noise to require removal. may i ask what compelled you to make this change?

@anhkhoakz
Copy link
Author

anhkhoakz commented Jul 7, 2025

Yes, I think it useful too. But when keeping it in the production, it prints out the console when I'm debugging another extension. Making it a little pollute

image

@backwardspy
Copy link
Member

i see, thanks for the info. i'd still rather not outright remove these, but we could maybe add a setting to disable them, or move them into their own log output channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants