Skip to content

feat: filter live e2e tests to only published templates #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

deloreyj
Copy link
Contributor

Description

This PR filters the templates we attempt to test when running the test:live:e2e command to only run against the templates that have live previews in the Cloudflare Dashboard.

Also fixes an issue where the live multiplayer globe template may have multiple users connected when the test runs.

Checklist

  • Template Metadata
    • template directory ends with -template
    • "cloudflare" section of package.json is populated
    • template preview image uploaded to Images
    • README is populated and uses <!-- dash-content-start --> and <!-- dash-content-end --> to designate the Dash readme preview
    • package.json contains a deploy command

Example package.json

"cloudflare": {
  "label": "Worker + D1 Database",
  "products": [
    "Workers",
    "D1"
  ],
  "categories": [
    "storage"
  ],
  "docs_url": "https://developers.cloudflare.com/d1/",
  "preview_image_url": "https://imagedelivery.net/wSMYJvS3Xw-n339CbDyDIA/cb7cb0a9-6102-4822-633c-b76b7bb25900/public"
}

Copy link
Contributor

Dashboard preview link

@deloreyj deloreyj merged commit 1173831 into main Jun 30, 2025
3 checks passed
@deloreyj deloreyj deleted the fix-tests branch June 30, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants