Skip to content

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Jun 7, 2024

Description

This replaces calls to logger.warn with logger.warning. The former has been deprecated since Python 3.3 and generates DeprecationWarnings that can make output particularly in debugging and testing more noisy than necessary.

Checklist - did you ...

As this is a purely internal change, I don't thing any of the following items apply.
Please do correct me if I am wrong.

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 7, 2024
@zklaus
Copy link
Contributor Author

zklaus commented Jun 7, 2024

pre-commit.ci autofix

Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #5364 will not alter performance

Comparing zklaus:warn-to-warning (c07e306) with main (cdca0b4)

Summary

✅ 3 untouched benchmarks

@zklaus zklaus marked this pull request as ready for review June 7, 2024 13:39
@zklaus zklaus requested a review from a team as a code owner June 7, 2024 13:39
@jaimergp
Copy link
Contributor

jaimergp commented Jun 7, 2024

Thanks! Next one in line, this hack in conda 😂

@zklaus
Copy link
Contributor Author

zklaus commented Jun 7, 2024

I can fire up the analogous conda PR. Thanks to @jaimergp's pointer, I found a simple ruff one-liner for this one.

@jezdez jezdez merged commit fc9a9f6 into conda:main Jun 7, 2024
@beeankha beeankha mentioned this pull request Jul 16, 2024
55 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 8, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants