Fix grid item width and height calculation for correct spacing #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct the formula for calculating grid item width to account for total gaps: (width - (_cols + 1) * gap) / _cols - Correct the formula for calculating grid item height to account for total gaps: (height - (_rows + 1) * gap) / _rows This fixes the issue where extra space appears on the right and bottom sides of the grid when grid cols or grid rows values differ from the grid gap value, ensuring even spacing throughout the grid.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Problem:
The current formula used to calculate grid item width and height is incorrect:
This formula mistakenly assumes the total width or height occupied by gaps is (gap + 1) times cols for width and (gap + 1) times rows for height, which is incorrect. The correct formula should consider the total number of gaps, which is (cols + 1) for width and (rows + 1) for height.
Solution:
The formulas have been updated to correctly calculate the width and height of grid items: