-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update all text references of Dashboard to Cloud #4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Remaining items to do:
|
fc7752f
to
83c247b
Compare
b79da84
to
ce90388
Compare
@debrisapron I rebased this morning and pulled in your latest changes from Master. I had one conflict with the Cloud Introduction page and cleared that up (your new header banner). Our plan is to merge this PR on 11/16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was on a PR review for an unrelated issue and realized that if we're renaming all of the existing /dashboard/*
URL's to cloud, that we need to add redirects for every renamed file inside of redirects.js
so users bookmarking old links get forwarded to the new ones.
I see that you did one indicated below... but I believe every existing /dashboard/*
URL needs to be redirected
The redirects file in the PR is here:
https://github.com/cypress-io/cypress-documentation/pull/4719/files#diff-0c2a003b2ed5170c245944b00d0738dcfd9ee35f449ffb10252b159c5a457af1
And here is the file directly:
https://github.com/cypress-io/cypress-documentation/blob/mvollmer-change-dashboard-to-cloud/redirects.js
You may be able to use like a glob or wildcard pattern to dynamically set the redirects, but worst case you'll just add a manual entry for each one.
@brian-mann I recall this coming up in a conversation months ago and I walked away with the understanding that only the netlify.toml file needed to be updated -- something about the redirects.js file you mentioned not actually doing anything. If this is untrue, I'll update redirects.js. |
Oh I could be totally wrong about the redirects... I just saw that edited and assumed that's where the functionality is. I didn't look at the Edit: I see you did in fact update netlify.toml - presumably you should be able to test this out in the preview environment and know the redirects are working as expected. If that's the case then dismiss my review, you already got everything. |
netlify.toml redirects were tested and worked in the netlify preview env
* updated all text references of Dashboard to Cloud * updated instances of "cloud service" * add redirects * update dashboard-faq.md filename * update guides/dashboard directory name * fixed netlify redirect * update overview video * test to kick off build * fix faq redirect * markdown lint fix Co-authored-by: Ely Lucas <[email protected]>
This PR should not be merged until we are ready to roll out the final rebrand on 11/16/22.