Skip to content

Update all text references of Dashboard to Cloud #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 17, 2022

Conversation

mattvollmer
Copy link
Contributor

@mattvollmer mattvollmer commented Sep 8, 2022

This PR should not be merged until we are ready to roll out the final rebrand on 11/16/22.

@mattvollmer mattvollmer requested a review from elylucas September 8, 2022 12:50
@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 9:15PM (UTC)

@mattvollmer mattvollmer changed the title updated all text references of Dashboard to Cloud Update all text references of Dashboard to Cloud Sep 12, 2022
@mattvollmer
Copy link
Contributor Author

mattvollmer commented Sep 12, 2022

Remaining items to do:

  • Update on.cypress.io/dashboard link to redirect to Cloud (Eng will handle)
  • Create on.cypress.io/cloud link and link to cloud.cypress.io (Eng will handle)
  • Update content/faq/dashboard-faq.md file name and all references
  • Update content/guides/dashboard directory and all references
  • Redirects for old dashboard links that are now cloud

@mattvollmer mattvollmer force-pushed the mvollmer-change-dashboard-to-cloud branch from b79da84 to ce90388 Compare November 11, 2022 14:27
@mattvollmer mattvollmer marked this pull request as ready for review November 11, 2022 14:30
@mattvollmer
Copy link
Contributor Author

@debrisapron I rebased this morning and pulled in your latest changes from Master. I had one conflict with the Cloud Introduction page and cleared that up (your new header banner). Our plan is to merge this PR on 11/16

Copy link
Member

@brian-mann brian-mann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on a PR review for an unrelated issue and realized that if we're renaming all of the existing /dashboard/* URL's to cloud, that we need to add redirects for every renamed file inside of redirects.js so users bookmarking old links get forwarded to the new ones.

I see that you did one indicated below... but I believe every existing /dashboard/* URL needs to be redirected

image

The redirects file in the PR is here:
https://github.com/cypress-io/cypress-documentation/pull/4719/files#diff-0c2a003b2ed5170c245944b00d0738dcfd9ee35f449ffb10252b159c5a457af1

And here is the file directly:
https://github.com/cypress-io/cypress-documentation/blob/mvollmer-change-dashboard-to-cloud/redirects.js

You may be able to use like a glob or wildcard pattern to dynamically set the redirects, but worst case you'll just add a manual entry for each one.

@mattvollmer
Copy link
Contributor Author

mattvollmer commented Nov 16, 2022

I was on a PR review for an unrelated issue and realized that if we're renaming all of the existing /dashboard/* URL's to cloud, that we need to add redirects for every renamed file inside of redirects.js so users bookmarking old links get forwarded to the new ones.

I see that you did one indicated below... but I believe every existing /dashboard/* URL needs to be redirected

image

The redirects file in the PR is here: https://github.com/cypress-io/cypress-documentation/pull/4719/files#diff-0c2a003b2ed5170c245944b00d0738dcfd9ee35f449ffb10252b159c5a457af1

And here is the file directly: https://github.com/cypress-io/cypress-documentation/blob/mvollmer-change-dashboard-to-cloud/redirects.js

You may be able to use like a glob or wildcard pattern to dynamically set the redirects, but worst case you'll just add a manual entry for each one.

@brian-mann I recall this coming up in a conversation months ago and I walked away with the understanding that only the netlify.toml file needed to be updated -- something about the redirects.js file you mentioned not actually doing anything.

https://github.com/cypress-io/cypress-documentation/blob/mvollmer-change-dashboard-to-cloud/netlify.toml

If this is untrue, I'll update redirects.js.

@brian-mann
Copy link
Member

brian-mann commented Nov 16, 2022

Oh I could be totally wrong about the redirects... I just saw that edited and assumed that's where the functionality is. I didn't look at the netlify.toml so if that's been updated to incorporate this then disregard my review

Edit: I see you did in fact update netlify.toml - presumably you should be able to test this out in the preview environment and know the redirects are working as expected. If that's the case then dismiss my review, you already got everything.

@mattvollmer mattvollmer dismissed brian-mann’s stale review November 16, 2022 17:38

netlify.toml redirects were tested and worked in the netlify preview env

@elylucas elylucas merged commit b4c44e9 into master Nov 17, 2022
@elylucas elylucas deleted the mvollmer-change-dashboard-to-cloud branch November 17, 2022 13:03
astone123 pushed a commit that referenced this pull request Nov 22, 2022
* updated all text references of Dashboard to Cloud

* updated instances of "cloud service"

* add redirects

* update dashboard-faq.md filename

* update guides/dashboard directory name

* fixed netlify redirect

* update overview video

* test to kick off build

* fix faq redirect

* markdown lint fix

Co-authored-by: Ely Lucas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants