Fixed #25281 -- Make permission strings unique to identify permissions.

[tsyplakou]

Fix not unique permission strings. From '"app_label.permission" to "app_label.model.permission". I used info from the ticket + google groups.

[carltongibson]

Hi. Thanks for this.

I think you need to posted to the mailing list thread to seek advice about implementation. Specifically we'd need to deprecated the existing behaviour, rather than just change it in one go.

It looks like Flavio had ideas:

My proposal is to temporarily supports two formats: the new app_label.model_name.codename (ref #25281) and the old app.codename. The old format will raise a PendingDeprecationWarning. Docs, code and tests will be updated to use the new format.

I wonder if he has that sketched out somewhere.

Is the addition of has_model_perms() a necessary part of this PR, or is it a separate issue?

I'd expect to see more significant docs changes, and we'll need release notes explaining the changes (plus deprecations.)

[tsyplakou]

I think you need to posted to the mailing list thread to seek advice about implementation. Specifically we'd need to deprecated the existing behaviour, rather than just change it in one go.

Thanks for the answer. What exactly you mean by above? Where need to post and how to deprecate the existing behaviour?

[carltongibson]

Hi!

The mailing list is the google group. I guess no harm in continuing the old thread.

There's a section on Deprecating a feature in the Submitting Patches docs.

[felixxm]

Closing due to inactivity and lack of consensus.