SHA256 missing from 2.10.0 release

[aminvakil]

Description

I rely on the existence of .sha256 of docker-compose binary for every release on my ansible task.

https://github.com/aminvakil/ansible-role-docker-installation/blob/20b7f6277fc942b47b6cff408c82b04c5f9e9b77/tasks/docker-compose.yml#L4

https://github.com/docker/compose/releases/download/v{{ docker_compose_version }}/docker-compose-{{ ansible_system }}-{{ ansible_architecture }}.sha256

And it is not present in 2.10.0 release anymore.

Steps to reproduce the issue:

1. Verify https://github.com/docker/compose/releases/download/v2.9.0/docker-compose-Linux-x86_64.sha256 works.
2. Try https://github.com/docker/compose/releases/download/v2.10.0/docker-compose-Linux-x86_64.sha256 and see failure.

Describe the results you received:
404

Describe the results you expected:
200

[aminvakil]

Sorry for bumping this issue with no additional information, but do you want to add checksum to this release or ?

[laurazard]

Hi @aminvakil, thanks for the report. In #9750 we stopped including the xxx.sha256 file you're looking for and started including a checksums.txt file with all the checksums, available here: https://github.com/docker/compose/releases/download/v2.10.0/checksums.txt

@aminvakil, How to get this working again in a saltstack way?

docker_repository:
  pkgrepo.managed:
   - humanname: Docker
   - name: deb https://download.docker.com/linux/ubuntu focal stable
   - dist: focal
   - file: /etc/apt/sources.list.d/docker.list
   - gpgcheck: 1
   - key_url: https://download.docker.com/linux/ubuntu/gpg


docker_pkg:
  pkg.installed:
    - pkgs:
      - docker-ce
      - docker-ce-cli
      - docker-compose-plugin
      - containerd.io
    - require:
      - docker_repository

I'm always running into:

----------
          ID: docker-compose-software-binary-install
    Function: file.managed
        Name: /usr/local/docker-compose-latest/bin//docker-compose
      Result: False
     Comment: Attempt 1: Returned a result of "False", with the following comment: "Unable to manage file: Error: HTTP 404: Not Found reading /docker/compose/releases/latest/download/docker-compose-Linux-x86_64.sha256"
              Attempt 2: Returned a result of "False", with the following comment: "Unable to manage file: Error: HTTP 404: Not Found reading /docker/compose/releases/latest/download/docker-compose-Linux-x86_64.sha256"
              Unable to manage file: Error: HTTP 404: Not Found reading /docker/compose/releases/latest/download/docker-compose-Linux-x86_64.sha256
     Started: 20:05:31.340670
    Duration: 131407.553 ms
     Changes:   
----------
          ID: docker-compose-software-binary-install-symlink-docker-compose
    Function: file.symlink
        Name: /usr/local/bin/docker-compose
      Result: False
     Comment: One or more requisite failed: docker.compose.software.binary.install.docker-compose-software-binary-install
     Started: 20:07:42.843606
    Duration: 0.004 ms
     Changes:   

[aminvakil]

@aminvakil, How to get this working again in a saltstack way?

No idea.

[stratusjerry]

Hi @aminvakil, thanks for the report. In #9750 we stopped including the xxx.sha256 file you're looking for and started including a checksums.txt file with all the checksums, available here: https://github.com/docker/compose/releases/download/v2.10.0/checksums.txt

@laurazard would it be possible to add it back? I'd be happy to submit a PR that uses sed and expands the checksum.txt into the separate .sha256 files. The files date back 4 years and I imagine a fair amount of pipelines and build systems like ansible, salt, chef, etc (saltstack-formulas/docker-formula#319) are breaking because of reliance on the files

I would also love to see the sha256 back. It also breaks our deployments. In Addition to this issue I also opened this issue in Saltstack's gut repo.

[milas]

We just released v2.10.1, which includes a bugfix for pull behavior in v2.10.0 and restores the individual .sha256 checksum files (see #9786).

Nice!

I can confirm that the issue is now gone and the states going through fine using salt stack:

----------
          ID: docker-compose-software-binary-install
    Function: file.managed
        Name: /usr/local/docker-compose-latest/bin//docker-compose
      Result: True
     Comment: File /usr/local/docker-compose-latest/bin//docker-compose updated
     Started: 18:36:15.711083
    Duration: 3687.117 ms
     Changes:   
              ----------
              diff:
                  New file
              mode:
                  0755
----------
          ID: docker-compose-software-binary-install-symlink-docker-compose
    Function: file.symlink
        Name: /usr/local/bin/docker-compose
      Result: True
     Comment: Created new symlink /usr/local/bin/docker-compose -> /usr/local/docker-compose-latest/bin//docker-compose
     Started: 18:36:19.398899
    Duration: 47.93 ms
     Changes:   
              ----------
              new:
                  /usr/local/bin/docker-compose
----------

Thank you all for quickly implementing

[aminvakil]

Thanks for bringing sha256s back, please continue adding checksums.txt as well if it's OK.