Skip to content

GCP: Redis Field Type Fix #10159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 28, 2024
Merged

GCP: Redis Field Type Fix #10159

merged 7 commits into from
Jun 28, 2024

Conversation

Linu-Elias
Copy link
Contributor

@Linu-Elias Linu-Elias commented Jun 17, 2024

Proposed commit message

GCP Redis field persistence.rdb.bgsave_in_progress had incorrect type.
This field was not used in the dashboards in the previous version.

Changed the GCP Redis field persistence.rdb.bgsave_in_progress type to boolean

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

I've tested with elastic-package, and run the tests for the respective package.

Related issues

Screenshots

@Linu-Elias Linu-Elias requested review from a team as code owners June 17, 2024 06:20
Copy link

cla-checker-service bot commented Jun 17, 2024

💚 CLA has been signed

@ishleenk17
Copy link
Member

@Linu-Elias : Please sign the CLA.

@gpop63 gpop63 requested review from gpop63 and lucian-ioan June 17, 2024 11:50
@gpop63 gpop63 added the Integration:gcp Google Cloud Platform label Jun 17, 2024
@gpop63
Copy link
Contributor

gpop63 commented Jun 17, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@gpop63 gpop63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make the changelog entry description a bit more descriptive.

@gpop63
Copy link
Contributor

gpop63 commented Jun 18, 2024

/test

Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Linu-Elias
Copy link
Contributor Author

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Linu-Elias

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Linu-Elias Linu-Elias merged commit a8a06ba into elastic:main Jun 28, 2024
5 checks passed
@elasticmachine
Copy link

Package gcp - 2.34.1 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Redis field persistence.rdb.bgsave_in_progress has wrong type
5 participants