Skip to content

o365: improve clarity of CEL code #13795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2025
Merged

o365: improve clarity of CEL code #13795

merged 5 commits into from
May 6, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 5, 2025

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

efd6 added 3 commits May 6, 2025 07:54
@efd6
o365: disentangle query construction from string operations
617846c
@efd6
o365: clean up indentation
a4b8f65 
It seems that line breaks over multi-clause expressions are not properly
handled by celfmt, so fix these manually.
@efd6
o365: remove redundant bytes conversions
e03221a
@efd6 efd6 added enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 5, 2025
@efd6 efd6 self-assigned this May 5, 2025
@efd6 efd6 force-pushed the s5934-o365-clarity branch from 2c05105 to 303025e Compare May 5, 2025 23:23
@efd6 efd6 mentioned this pull request May 5, 2025
Closed
@efd6
Copy link
Contributor Author

efd6 commented May 5, 2025

/test

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 6, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review May 6, 2025 00:09
@efd6 efd6 requested a review from a team as a code owner May 6, 2025 00:09
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

kcreddy
kcreddy approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 4133436 into elastic:main May 6, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package o365 - 2.15.0 containing this change is available at https://epr.elastic.co/package/o365/2.15.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy