Skip to content

[Prometheus] SSL verification mode not respected, when no bearer token is set. #14526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2025

Conversation

Alphayeeeet
Copy link
Contributor

Please label as bugfix

Proposed commit message

Fixed ssl-verification-mode not respected, when no bearer token is set.

When no bearer token was set, then any set ssl verification-mode was not respected.

@Alphayeeeet Alphayeeeet requested a review from a team as a code owner July 14, 2025 06:41
@mykola-elastic mykola-elastic added Integration:prometheus Prometheus Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] bugfix Pull request that fixes a bug issue labels Jul 14, 2025
@Alphayeeeet
Copy link
Contributor Author

@mykola-elastic Has been fixed. Please re-review and run CI accordingly. Thanks

@ishleenk17
Copy link
Member

/test

@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 Is it possible to leave a review as member of infraobs team? Thank you

@ishleenk17 ishleenk17 enabled auto-merge (squash) July 14, 2025 17:29
@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 Please run CI again. Due to the merge, a new test run is necessary. Thanks

@ishleenk17
Copy link
Member

/test

@ishleenk17 ishleenk17 merged commit ff66076 into elastic:main Jul 14, 2025
7 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

@elastic-vault-github-plugin-prod

Package prometheus - 1.24.1 containing this change is available at https://epr.elastic.co/package/prometheus/1.24.1/

@Alphayeeeet Alphayeeeet deleted the hotfix-prometheus-ssl-fields branch July 22, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:prometheus Prometheus Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants