Skip to content

[gcp] Update DNS Logs #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 28, 2022
Merged

[gcp] Update DNS Logs #2340

merged 19 commits into from
Jul 28, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Dec 14, 2021 •
edited
Loading

What does this PR do?

Enhances the log enrichment/normalization for GCP DNS logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 66f4d1a to 82368ef Compare December 15, 2021 23:04
@legoguy1000 legoguy1000 marked this pull request as ready for review December 15, 2021 23:04
@elasticmachine
Copy link

elasticmachine commented Dec 15, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T07:23:44.825+0000

  • Duration: 20 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000
Copy link
Contributor Author

@kaiyan-sheng could you run tests for this too?

@kaiyan-sheng
Copy link
Contributor

/test

@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch 3 times, most recently from 5a13d7a to eb0c6ad Compare January 5, 2022 00:24
@legoguy1000
Copy link
Contributor Author

OK, i think it should be fixed now.

@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch from eb0c6ad to ae69047 Compare February 4, 2022 03:09
@legoguy1000
Copy link
Contributor Author

@kaiyan-sheng can we rerun tests on this?

@kaiyan-sheng
Copy link
Contributor

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Feb 4, 2022

This needs to have the version bumped in manifest.yml.

efd6
efd6 reviewed Feb 4, 2022
View reviewed changes
@legoguy1000
Copy link
Contributor Author

fixes pushed.

@legoguy1000 legoguy1000 requested a review from efd6 February 10, 2022 04:33
@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 945724f to 58b4098 Compare February 10, 2022 05:20
@efd6
Copy link
Contributor

efd6 commented Feb 10, 2022

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Feb 10, 2022

/test

@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch from aeeaedf to f544ceb Compare February 11, 2022 21:09
@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Feb 11, 2022
@andrewkroh andrewkroh changed the title GCP DNS public query logs [gcp] Add DNS Public Zone Query Logs Apr 6, 2022
@legoguy1000 legoguy1000 marked this pull request as ready for review July 12, 2022 00:25
@legoguy1000 legoguy1000 requested review from a team as code owners July 12, 2022 00:25
@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 864e30b to 84a3eb0 Compare July 12, 2022 00:28
@legoguy1000
Copy link
Contributor Author

I rebased and merged the datastreams should be GTG.

@efd6
Copy link
Contributor

efd6 commented Jul 12, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Jul 12, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 2.988
Classes 100.0% (4/4) 💚 2.988
Methods 94.03% (63/67) 👍 4.315
Lines 95.443% (1173/1229) 👍 4.021
Conditionals 100.0% (0/0) 💚

@legoguy1000 legoguy1000 changed the title [gcp] Add DNS Public Zone Query Logs [gcp] Update DNS Logs Jul 12, 2022
@legoguy1000 legoguy1000 requested a review from a team as a code owner July 23, 2022 19:02
@legoguy1000 legoguy1000 force-pushed the gcp-dns-public-query-logs branch from 78f8eee to 3fc2931 Compare July 23, 2022 19:03
@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

/test

efd6
efd6 reviewed Jul 25, 2022
View reviewed changes
@legoguy1000
Copy link
Contributor Author

@efd6 comments addressed

@efd6
Copy link
Contributor

efd6 commented Jul 26, 2022

/test

@efd6 efd6 merged commit 26aa970 into elastic:main Jul 28, 2022
@legoguy1000 legoguy1000 deleted the gcp-dns-public-query-logs branch July 28, 2022 02:00
@andrewkroh andrewkroh mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legoguy1000 @elasticmachine @kaiyan-sheng @efd6 @andrewkroh