Skip to content

gcp: remove gcp.audit.* fields duplicated in ECS fields #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 28, 2022

What does this PR do?

This resolves a set of TODOs by removing duplicated fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:gcp Google Cloud Platform labels Jun 28, 2022
@efd6 efd6 requested a review from r00tu53r June 28, 2022 03:05
@efd6 efd6 self-assigned this Jun 28, 2022
@efd6 efd6 requested review from a team as code owners June 28, 2022 03:05
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T22:56:37.308+0000

  • Duration: 32 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 93.939% (62/66)
Lines 95.21% (1113/1169)
Conditionals 100.0% (0/0) 💚

@andrewkroh
Copy link
Member

@r00tu53r Can you please take a look as this appears related to an earlier change of yours.

Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 thank you for addressing the TODOs. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:gcp Google Cloud Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gcp]: Remove duplicate fields
4 participants