Refactor NativeWindow (Part 2): NativeWindow is no longer WebContentsObserver #12140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS current draggable region implementation highly relies on WebContents, the code is only meaningful for BrowserWindow.
No need to store it separately in subclasses.
3c53f70 to
7846809
Compare
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the changes to decouple
NativeWindowfromWebContents, so it would be possible for us to implement new APIs based onNativeWindow, e.g. providing APIs to create native GUI elements without usingWebContents.This PR removes
WebContentsObserverfromNativeWindow's super classes.