Skip to content

feat: CSS nesting baseline support #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

rviscomi
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Add support for evaluating baseline support for CSS nesting

What changes did you make? (Give an overview)

  • added a test for CSS nesting
  • added a handler for the NestingSelector key that checks for nesting selector availability
  • added a check to isSupported so unknown feature statuses are supported by default (if the nesting ID happens to change, the test will fail and there won't be a runtime error)

Related Issues

fixes #85

Is there anything you'd like reviewers to focus on?

Should the nesting selector ID be saved as a constant somewhere, or is it ok to hard-code it in the NestingSelector handler?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should the nesting selector ID be saved as a constant somewhere, or is it ok to hard-code it in the NestingSelector handler?

I think it's fine to keep it local to where it's being used. 👍

@nzakas nzakas merged commit 8fcae6c into eslint:main Mar 17, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: Check CSS nesting syntax for baseline availability
2 participants