Skip to content

op-node: fix reset-confirmed metadata #15588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Conversation

protolambda
Copy link
Contributor

Description

There are no usages of this field besides logging, and so no affect on the outcome, but it was set wrong nevertheless.

@protolambda protolambda requested review from a team as code owners April 28, 2025 16:32
@protolambda protolambda requested a review from sebastianst April 28, 2025 16:32
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (2cb6ab9) to head (8f3a689).
Report is 200 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15588       +/-   ##
============================================
+ Coverage    46.72%   91.99%   +45.26%     
============================================
  Files         1285      129     -1156     
  Lines       106368     6819    -99549     
============================================
- Hits         49702     6273    -43429     
+ Misses       53168      534    -52634     
+ Partials      3498       12     -3486     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1159 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastianst sebastianst added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@protolambda protolambda added this pull request to the merge queue May 20, 2025
Merged via the queue into develop with commit ddbb1a1 May 20, 2025
54 checks passed
@protolambda protolambda deleted the fix-reset-confirmed branch May 20, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants