Skip to content

op-node: remove incomplete interop StandardMode #15996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Conversation

protolambda
Copy link
Contributor

Description

This removes the StandardMode scaffolding, since op-node now will prioritize ManagedMode, and soon unify that by removing the legacy mode of operation.

Tests

This scaffolding was not covered in testing. We are removing it now.

Additional context

Metadata

Fix #15995

@protolambda protolambda requested a review from ajsutton May 19, 2025 12:24
@protolambda protolambda requested review from a team as code owners May 19, 2025 12:24
@protolambda protolambda requested a review from sebastianst May 19, 2025 12:24
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (83b7e9a) to head (a41666a).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15996       +/-   ##
============================================
+ Coverage    81.40%   96.24%   +14.84%     
============================================
  Files          161      106       -55     
  Lines         8812     4575     -4237     
============================================
- Hits          7173     4403     -2770     
+ Misses        1506      172     -1334     
+ Partials       133        0      -133     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@protolambda protolambda added this pull request to the merge queue May 19, 2025
Merged via the queue into develop with commit 7aae451 May 19, 2025
60 checks passed
@protolambda protolambda deleted the rm-standard-mode branch May 19, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-node: interop: remove StandardMode
2 participants