Skip to content

op-node: Only deploy CrossL2Inbox if there is more than one chain in the dependency set #16042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented May 21, 2025

Description

Makes the deployment of CrossL2Inbox predeploy conditional on their being more than one chain in the dependency set. As there isn't currently support for adding chains to the dependency set, the condition is currently only checked at the interop activation block - when adding chains is supported this will have to be expanded to check at the block the dependency set actually changes. That's not implemented now because there isn't even a mechanism to specify the timestamp that a dependency set change activates at yet.

Most of the changes are plumbing to pass the dependency set through to the attributes builder so it can determine which upgrade transactions are required.

Metadata

#16041

@ajsutton ajsutton force-pushed the aj/predeploy-on-depset-spike branch 2 times, most recently from 596f7cd to 316a83a Compare May 21, 2025 01:25
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (6bf2ef5) to head (5cdec51).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16042       +/-   ##
============================================
+ Coverage    82.34%   96.24%   +13.89%     
============================================
  Files          161      106       -55     
  Lines         8812     4575     -4237     
============================================
- Hits          7256     4403     -2853     
+ Misses        1416      172     -1244     
+ Partials       140        0      -140     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ajsutton ajsutton changed the title op-node: Switch interop predeploys to deploy based on dep set op-node: Switch interop predeploys to deploy based on dep set (spike) May 22, 2025
@ajsutton ajsutton force-pushed the aj/predeploy-on-depset-spike branch 2 times, most recently from c23dbf9 to 23c422b Compare May 23, 2025 02:54
@ajsutton ajsutton changed the base branch from develop to aj/run-task-directly May 23, 2025 03:02
@ajsutton ajsutton force-pushed the aj/predeploy-on-depset-spike branch from 23c422b to 3ef2c43 Compare May 23, 2025 03:07
@ajsutton ajsutton force-pushed the aj/run-task-directly branch from b8b7e31 to 1beb10a Compare May 27, 2025 20:16
Base automatically changed from aj/run-task-directly to develop May 27, 2025 20:56
@tynes tynes added the H-interop Hardfork: change planned for interop upgrade label May 27, 2025
@ajsutton ajsutton force-pushed the aj/predeploy-on-depset-spike branch 2 times, most recently from d8688a1 to 1b7bd04 Compare May 28, 2025 04:39
@ajsutton ajsutton changed the base branch from develop to aj/depset-api May 28, 2025 04:39
@tynes
Copy link
Contributor

tynes commented May 28, 2025

Clarifying that based on ethereum-optimism/specs#707, the L2ToL2CrossDomainMessenger will always be deployed and the CrossL2Inbox will be deployed if the depset > 1

Base automatically changed from aj/depset-api to develop May 28, 2025 20:28
@ajsutton ajsutton force-pushed the aj/predeploy-on-depset-spike branch from 1b7bd04 to dc49894 Compare May 29, 2025 00:20
@ajsutton
Copy link
Contributor Author

Clarifying that based on ethereum-optimism/specs#707, the L2ToL2CrossDomainMessenger will always be deployed and the CrossL2Inbox will be deployed if the depset > 1

Yes the implementation does this, just the description and title was written way back before the details were known.

@ajsutton ajsutton marked this pull request as ready for review May 29, 2025 03:38
@ajsutton ajsutton requested review from a team as code owners May 29, 2025 03:38
@ajsutton ajsutton changed the title op-node: Switch interop predeploys to deploy based on dep set (spike) op-node: Only deploy CrossL2Inbox if there is more than one chain in the dependency set May 29, 2025
@ajsutton ajsutton force-pushed the aj/predeploy-on-depset-spike branch from dc49894 to 5cdec51 Compare May 29, 2025 22:50
@ajsutton ajsutton enabled auto-merge May 29, 2025 22:51
@ajsutton ajsutton added this pull request to the merge queue May 29, 2025
Merged via the queue into develop with commit 71c584b May 29, 2025
58 of 59 checks passed
@ajsutton ajsutton deleted the aj/predeploy-on-depset-spike branch May 29, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H-interop Hardfork: change planned for interop upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants