-
Notifications
You must be signed in to change notification settings - Fork 3.6k
op-node: Only deploy CrossL2Inbox if there is more than one chain in the dependency set #16042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
596f7cd
to
316a83a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16042 +/- ##
============================================
+ Coverage 82.34% 96.24% +13.89%
============================================
Files 161 106 -55
Lines 8812 4575 -4237
============================================
- Hits 7256 4403 -2853
+ Misses 1416 172 -1244
+ Partials 140 0 -140
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c23dbf9
to
23c422b
Compare
23c422b
to
3ef2c43
Compare
b8b7e31
to
1beb10a
Compare
d8688a1
to
1b7bd04
Compare
Clarifying that based on ethereum-optimism/specs#707, the |
1b7bd04
to
dc49894
Compare
Yes the implementation does this, just the description and title was written way back before the details were known. |
…he dependency set.
op-test-sequencer/sequencer/backend/work/builders/standardbuilder/config.go
Outdated
Show resolved
Hide resolved
dc49894
to
5cdec51
Compare
Description
Makes the deployment of
CrossL2Inbox
predeploy conditional on their being more than one chain in the dependency set. As there isn't currently support for adding chains to the dependency set, the condition is currently only checked at the interop activation block - when adding chains is supported this will have to be expanded to check at the block the dependency set actually changes. That's not implemented now because there isn't even a mechanism to specify the timestamp that a dependency set change activates at yet.Most of the changes are plumbing to pass the dependency set through to the attributes builder so it can determine which upgrade transactions are required.
Metadata
#16041