-
Notifications
You must be signed in to change notification settings - Fork 3.6k
op-node: Add dependency set flag #16094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required when interop fork is scheduled. Makes the dependency set available on the node config but it isn't currently used. Will unblock updating kurtosis to provide the depset config file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16094 +/- ##
============================================
+ Coverage 82.39% 96.24% +13.84%
============================================
Files 181 106 -75
Lines 10519 4575 -5944
============================================
- Hits 8667 4403 -4264
+ Misses 1699 172 -1527
+ Partials 153 0 -153
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sebastianst
added a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 23, 2025
sebastianst
added a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 23, 2025
janjakubnanista
approved these changes
May 23, 2025
protolambda
approved these changes
May 23, 2025
auto-merge was automatically disabled
May 23, 2025 14:21
Pull Request is not mergeable
sebastianst
added a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 27, 2025
janjakubnanista
pushed a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 27, 2025
janjakubnanista
pushed a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 27, 2025
sebastianst
added a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 27, 2025
Consequence of ethereum-optimism/optimism#16094 --------- Co-authored-by: Ján Jakub Naništa <[email protected]>
janjakubnanista
added a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 27, 2025
Consequence of ethereum-optimism/optimism#16094 --------- Co-authored-by: Ján Jakub Naništa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a dependency-set CLI flag to op-node. Currently it is completely optional and unused other than being added to the node Config.
This PR is really just to unblock updating the kurtosis optimism-package so it can set the depset before landing other parts of #16042 which will actually start using it and make it a required arg when interop fork is scheduled.
Metadata
#16041