Skip to content

op-test-sequencer: support for L1 reorgs #16105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

nonsense
Copy link
Contributor

@nonsense nonsense commented May 23, 2025

Description

This PR is:

  1. Adding builder/signer/publisher/sequencer for L1 to the op-test-sequencer, enabling it to produce L1 reorgs
  2. Adding a test that triggers a L1 reorg, and checks if eventually the L2 chain is also reorged and uses valid L1Origin references, and does not reference reorged L1 blocks.

Tests

TestL2ReorgAfterL1Reorg

Additional context

Related: #16052

Metadata

Fixes: #16061
Fixes: #15331
Fixes: #15333
Fixes: #14128

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e6848b1) to head (7ca98da).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16105       +/-   ##
============================================
- Coverage    46.54%        0   -46.55%     
============================================
  Files         1364        0     -1364     
  Lines       110451        0   -110451     
============================================
- Hits         51413        0    -51413     
+ Misses       55417        0    -55417     
+ Partials      3621        0     -3621     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1364 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch 2 times, most recently from f0a44bc to 5bcf48d Compare May 27, 2025 10:11
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch 2 times, most recently from de24377 to 4345ee5 Compare May 28, 2025 10:57
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 4fd48ac to b6292aa Compare May 28, 2025 11:08
@nonsense nonsense marked this pull request as ready for review May 28, 2025 12:48
@nonsense nonsense requested review from a team as code owners May 28, 2025 12:48
@nonsense nonsense requested review from geoknee, pcw109550 and protolambda and removed request for a team May 28, 2025 12:48
@nonsense nonsense self-assigned this May 28, 2025
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from f9784e9 to 699f107 Compare May 28, 2025 17:55
@nonsense nonsense requested a review from a team as a code owner May 28, 2025 17:55
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch from 4345ee5 to fae96b8 Compare May 28, 2025 18:13
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch 2 times, most recently from 0b82ca0 to 233f704 Compare May 28, 2025 21:14
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch from fae96b8 to b55cef2 Compare May 29, 2025 11:26
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 233f704 to d30b0d4 Compare May 29, 2025 11:30
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch from b55cef2 to 633bfea Compare May 29, 2025 11:31
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from d30b0d4 to 94d997b Compare May 29, 2025 11:31
Copy link
Contributor

@pcw109550 pcw109550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestL2ReorgAfterL1Reorg looks good to me.

Gave a first-pass review (excluding the newly added op-test-sequencer code). Will do a second review as a follow-up to cover that part.

@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 22febcd to 88c3e99 Compare May 30, 2025 10:57
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch 2 times, most recently from 0b9e712 to 965af03 Compare May 30, 2025 13:29
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 88c3e99 to 888d71c Compare May 30, 2025 13:31
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from b0794f9 to 3809431 Compare June 2, 2025 11:06
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch from c3360e3 to 8cc0668 Compare June 2, 2025 11:26
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 3809431 to 7092c6e Compare June 2, 2025 11:27
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 44613ab to 0e1ed18 Compare June 2, 2025 13:31
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe branch from 8cc0668 to 957c538 Compare June 3, 2025 10:26
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 0e1ed18 to 001f072 Compare June 3, 2025 10:26
Base automatically changed from nonsense/reset-local-unsafe to develop June 3, 2025 15:48
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 283e85c to e9c92c8 Compare June 3, 2025 15:50
@nonsense nonsense requested review from teddyknox and removed request for protolambda June 3, 2025 16:01
@teddyknox teddyknox removed the request for review from a team June 3, 2025 16:02
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch 2 times, most recently from dce00b5 to ad86995 Compare June 3, 2025 18:34
@nonsense nonsense enabled auto-merge June 4, 2025 10:54
Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the .dockerignore changes as codeowner.

@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 7f197eb to c6d41d2 Compare June 4, 2025 11:54
@nonsense nonsense added this pull request to the merge queue Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from c6d41d2 to 2220dd8 Compare June 4, 2025 13:01
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 2220dd8 to 7ca98da Compare June 4, 2025 13:04
@nonsense nonsense added this pull request to the merge queue Jun 4, 2025
Merged via the queue into develop with commit b67c2d9 Jun 4, 2025
59 checks passed
@nonsense nonsense deleted the nonsense/reset-local-unsafe-with-test branch June 4, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants