Skip to content

op-batcher: more robust detection of not-ready syncStatus #16298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 8, 2025

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Jun 5, 2025

This is a more robust way of detecting an invalid or "not yet ready" sync status. A valid status may have a 0 L2 safe block number, but the block hash would be the genesis block and therefore nonzero.

This should also allow us to safely run the batcher with --prefer-local-safe-l2=true even before we have fully resolved #14576

this is a more robust way of detecting an invalid or "not yet ready" sync status
@geoknee geoknee requested review from a team as code owners June 5, 2025 14:40
@geoknee geoknee requested a review from smartcontracts June 5, 2025 14:40
@geoknee geoknee enabled auto-merge June 8, 2025 13:59
@geoknee geoknee added this pull request to the merge queue Jun 8, 2025
Merged via the queue into develop with commit 2563ae1 Jun 8, 2025
59 checks passed
@geoknee geoknee deleted the gk/batcher-local-safe branch June 8, 2025 14:14
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6a8b234) to head (65e7726).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16298       +/-   ##
============================================
- Coverage    46.62%        0   -46.63%     
============================================
  Files         1368        0     -1368     
  Lines       110835        0   -110835     
============================================
- Hits         51675        0    -51675     
+ Misses       55514        0    -55514     
+ Partials      3646        0     -3646     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1368 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-node: syncStatus can report LocalSafeL2 of zero even when SafeL2 is nonzero
2 participants