Skip to content

op-node: Search valid unsafe head backwards #16312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Jun 6, 2025

Description

Changes the search for the latest valid unsafe head (valid per canonical L1 origin) in the supervisor-instructed reset to go backwards. L1 reorgs are usually shallow, and resets sometimes are for other reasons than an L1 reorg, so going backwards will almost always be a much quicker option.

Tests

Existing L1 reorg acceptance tests should still pass.

Additional context

The old forwards-search prevented some nodes on the rehearsal network from resetting in time. With backwards search, they got unstuck.

We will probably switch to a binary search with #16276

@sebastianst sebastianst requested a review from nonsense June 6, 2025 09:51
@sebastianst sebastianst requested review from a team as code owners June 6, 2025 09:51
@sebastianst sebastianst requested a review from protolambda June 6, 2025 09:51
@sebastianst sebastianst force-pushed the seb/backwards-valid-unsafe branch from f6d018e to 9ae8b86 Compare June 6, 2025 10:00
@sebastianst sebastianst force-pushed the seb/backwards-valid-unsafe branch from 9ae8b86 to 4fc13cb Compare June 6, 2025 10:06
@sebastianst sebastianst enabled auto-merge June 6, 2025 10:09
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (158e990) to head (d81b2a1).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16312       +/-   ##
============================================
+ Coverage    46.67%   96.24%   +49.57%     
============================================
  Files         1368      106     -1262     
  Lines       110795     4583   -106212     
============================================
- Hits         51714     4411    -47303     
+ Misses       55435      172    -55263     
+ Partials      3646        0     -3646     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1262 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastianst sebastianst added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2025
@sebastianst sebastianst force-pushed the seb/backwards-valid-unsafe branch from 4fc13cb to d81b2a1 Compare June 6, 2025 14:23
@sebastianst sebastianst added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2025
@ajsutton ajsutton added this pull request to the merge queue Jun 8, 2025
Merged via the queue into develop with commit cbc78c9 Jun 8, 2025
61 checks passed
@ajsutton ajsutton deleted the seb/backwards-valid-unsafe branch June 8, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants