Skip to content

op-batcher: remove preferLocalSafeL2 flag #16413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025
Merged

op-batcher: remove preferLocalSafeL2 flag #16413

merged 4 commits into from
Jun 16, 2025

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Jun 13, 2025

This behavior now becomes the default (in fact, the only) behavior. We only had this configurable before to cope with bugs in op-node (#14576 ) which we believe are now either fixed or worked around adequately by the batcher.

#16298
#16296

This behavior now becomes the default (in fact, the only) behavior. We only had this configurable before to cope with bugs in op-node which we believe are now either fixed or worked around adequately by the batcher.
@geoknee geoknee requested review from a team as code owners June 13, 2025 10:42
@geoknee geoknee requested a review from axelKingsley June 13, 2025 10:42
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b227d03) to head (b3191c9).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16413       +/-   ##
============================================
- Coverage    47.08%        0   -47.09%     
============================================
  Files         1388        0     -1388     
  Lines       112185        0   -112185     
============================================
- Hits         52819        0    -52819     
+ Misses       55658        0    -55658     
+ Partials      3708        0     -3708     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1388 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see one suggestion to keep a local variable for readability.

@geoknee geoknee added this pull request to the merge queue Jun 16, 2025
Merged via the queue into develop with commit 1809039 Jun 16, 2025
60 checks passed
@geoknee geoknee deleted the gk/batcher-safe-l2 branch June 16, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants