Skip to content

[BACKPORT v0.4.0] Revert new scripts #16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Jun 17, 2025

This reverts commit c22f8d2.

Version 0.4.0 of op-deployer was incorrectly pointed at develop smart contracts. The EVM Safety team fixed this by cherry-picking a subset of the changes on develop onto the proposal branch. However, this broke op-deployer since the fixed contracts no longer supported the new-style scripts that used structs and return values rather than I/O contracts.

This PR reverts the cutover to the new-style scripts so that v0.4.* of op-deployer can continue functioning correctly.

… new scripts for DeploySuperchain & DeployImplementations [17/N] (#15551)"

This reverts commit c22f8d2.
@mslipper mslipper requested review from a team as code owners June 17, 2025 22:21
@mslipper mslipper requested review from maurelian and serpixel June 17, 2025 22:21
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed by confirming that this is a clean revert of c22f8d2

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding approval to unblock. @maurelian reviewed the revert here

@mslipper
Copy link
Collaborator Author

needs two contract reviewers

@mds1 mds1 merged commit f34669c into backports/op-deployer/v0.4.0 Jun 18, 2025
58 checks passed
@mds1 mds1 deleted the feat/revert-new-scripts branch June 18, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants