Skip to content

Update standard.go for rc.8 #16505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2025

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Jun 18, 2025

@maurelian maurelian requested a review from a team as a code owner June 18, 2025 19:54
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.84%. Comparing base (f34669c) to head (e1ce919).
Report is 1 commits behind head on backports/op-deployer/v0.4.0.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           backports/op-deployer/v0.4.0   #16505       +/-   ##
=================================================================
+ Coverage                         46.90%   65.84%   +18.93%     
=================================================================
  Files                              1363       55     -1308     
  Lines                            109923     4283   -105640     
=================================================================
- Hits                              51560     2820    -48740     
+ Misses                            54719     1330    -53389     
+ Partials                           3644      133     -3511     
Flag Coverage Δ
cannon-go-tests-64 65.84% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1308 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mslipper
Copy link
Collaborator

you will need to update the SR version for tests to pass

@maurelian maurelian requested a review from a team as a code owner June 20, 2025 17:10
@maurelian maurelian requested a review from Inphi June 20, 2025 17:10
@maurelian
Copy link
Contributor Author

you will need to update the SR version for tests to pass

OK, done. 82f3b28

@mslipper
Copy link
Collaborator

hmm no that's the SCR in the contracts - you need to revert and update the SCR in the go mod. like this, from the root of the repo:

go get -u github.com/ethereum-optimism/superchain-registry/validation@<latest SR SHA>
go mod tidy

@maurelian maurelian force-pushed the fixes/deployer-v0.4.0-rc.5 branch from 82f3b28 to e8634c4 Compare June 20, 2025 18:04
maurelian and others added 3 commits June 20, 2025 15:24
* op-deployer: Add support for upgrading to v4.0.0

* simplify versions

* rebase, add validator v4 support

* update address test

* lint
@mslipper mslipper merged commit 7fe5d2c into backports/op-deployer/v0.4.0 Jun 21, 2025
48 of 57 checks passed
@mslipper mslipper deleted the fixes/deployer-v0.4.0-rc.5 branch June 21, 2025 04:10
mslipper added a commit that referenced this pull request Jun 24, 2025
* Update standard.go for rc.8

* Update superchain registry with op-contracts/v4.0.0-rc.8

* Update Validator address

* Update registry commit

* op-deployer: Add support for upgrading and validating v4.0.0 (#16048)

* op-deployer: Add support for upgrading to v4.0.0

* simplify versions

* rebase, add validator v4 support

* update address test

* lint

---------

Co-authored-by: Matthew Slipper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants