op-service,op-supervisor: Correctly detect ethereum.NotFound in RPCs

[sebastianst]

Description

The ethereum.NotFound error can be lost across RPC boundaries. This PR fixes our L2 source and Interop RPC clients to heuristically detect this error and forward it internally accordingly. This is important because this error is often treated in a special way. The heuristic is isolated into a new function eth.MaybeAsNotFoundErr(err) for reuse.

Tests

Unit tests added for the new MaybeAsNotFoundErr function.

Additional context

Without this, Interop resets don't work because the bisection checks for this error but the RPC client didn't produce it correctly.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1515740) to head (d8f9519).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #16555       +/-   ##
============================================
- Coverage    77.18%        0   -77.19%     
============================================
  Files          166        0      -166     
  Lines         9507        0     -9507     
============================================
- Hits          7338        0     -7338     
+ Misses        2019        0     -2019     
+ Partials       150        0      -150     

Flag	Coverage Δ
cannon-go-tests-64	?
contracts-bedrock-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 166 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[protolambda]

The EthClient.payloadCall, EthClient.headerCall, EthClient.blockCall inner methods should be getting this error check. The methods that were changed here just wrap those 3 inner methods. If the inner methods handle the error, then we don't have to repeat it in every usage. Also see other comment about the existing nil checks (the standard way of communicating not-found in RPC for blocks). But these 3 methods miss the error inspection when the error is non-nil.

[protolambda]

Very nice