Fix implementation of Ord for Prop #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the implementation of `<=` for Prop would not obey the antisymmetry law, I believe in the case of `PEq` specifically. This leads to weird behaviour, namely that duplicates are not properly recognized in Set. The proposed change is to implement `compare` directly, which I think is easier than trying to fix `<=`.
msooseth
approved these changes
May 16, 2025
| @@ -80,6 +80,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| we now try best to print everything we can, and print an appropriate error message | |||
| instead of crashing. | |||
| - We no longer produce duplicate SMT assertions regarding concrete keccak values. | |||
| - Ord is now correctly implemented for Prop. | |||
There was a problem hiding this comment.
This might be optimistic from me :)
Time will tell...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the implementation of
<=for Prop would not obey the antisymmetry law, I believe in the case ofPEqspecifically. This leads to weird behaviour, namely that duplicates are not properly recognized in Set.The proposed change is to implement
comparedirectly, which I think is easier than trying to fix<=.Checklist