Skip to content

fix(): FabricImage was missing cachekey when filtering #10441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2025

Conversation

asturur
Copy link
Member

@asturur asturur commented Feb 14, 2025

Description

When converting image to TS, the cacheKey parameter during the function call was deleted.
Fixes #10436
close #10436

Copy link

codesandbox bot commented Feb 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@asturur
Copy link
Member Author

asturur commented Feb 14, 2025

Requires some kind of test

Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 923.327 (+0.015) 306.746 (+0.014)

Copy link
Contributor

Coverage after merging missing-image-cachekey into master will be

86.43%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
fabric.ts86.92%20%0%95.79%10, 144, 144, 144, 144, 144, 190, 190, 190, 190, 190, 31, 33, 33, 33, 33, 33–34, 34, 34, 34, 34, 39, 8
index.node.ts14.29%100%0%25%23, 26, 29, 41, 44, 47
extensions/aligning_guidelines/util
   basic.ts100%100%100%100%
extensions/data_updaters/origins
   index.ts97.50%75%100%100%22–23
src
   ClassRegistry.ts91.18%64.29%100%97.92%35, 56
   Collection.ts78.71%44.62%87.10%86.21%130, 153, 155–157, 159, 169–170, 181, 197, 217, 228, 241, 243, 252, 254, 265, 270, 279, 281, 286–287, 302, 304, 309–310, 329, 333–334, 338–344, 346–348, 350
   CommonMethods.ts91.43%71.43%100%96%50, 52
   EventTypeDefs.ts100%100%100%100%
   Intersection.ts85.25%48.91%100%97.30%184–188, 190, 228, 237, 239, 289, 297, 297
   Observable.ts80.63%53.49%93.75%87.88%144, 153, 156, 168, 170, 175, 68–70, 72, 76, 80, 84–85, 87–91
   Point.ts90.53%62%100%93.90%104, 117, 148, 157, 179, 197, 206, 216, 225, 236–239, 259, 285, 297, 328, 341, 349, 359, 95
   Shadow.ts89.21%78.26%100%90%140, 143, 145–150, 159, 196, 199, 206, 223–230, 234–235
   cache.ts84.88%45.45%100%90.14%57, 59, 71–72, 74–77
   config.ts88.02%55%66.67%94.20%136, 138–141, 143, 146–147, 151, 156
   constants.ts100%100%100%100%
   typedefs.ts100%100%100%100%
src/LayoutManager
   ActiveSelectionLayoutManager.ts93.33%76.92%85.71%100%
   LayoutManager.ts90.75%65.48%76.92%99.31%279, 344, 355
   constants.ts100%100%100%100%
   index.ts48.57%37.50%80%66.67%1, 1, 1–2, 2, 2–3, 3, 3–4, 4, 4–5, 5, 5, 5–6
   types.ts100%100%100%100%
src/LayoutManager/LayoutStrategies
   ClipPathLayout.ts75%56.25%100%78.95%39, 41–44, 46–48, 66–69
   FitContentLayout.ts100%100%100%100%
   FixedLayout.ts85.71%20%100%100%23, 23
   LayoutStrategy.ts89.26%60.71%100%97.67%54, 73, 75
   utils.ts72.58%50%100%78.72%29–32, 34–35, 40–44
src/Pattern
   Pattern.ts67.50%88.57%80%63.08%105–107, 114, 118–119, 119–122, 130–138, 140–141, 143, 153–164, 174, 176–181, 183–188, 190–199, 203–206, 209–210, 212–214, 216–218, 218–221, 33, 37
   index.ts50%100%100%50%2
   types.ts100%100%100%100%
src/brushes
   BaseBrush.ts89.33%91.67%100%88.55%110, 115, 124–125, 130, 135, 143, 146, 155–160, 99
   CircleBrush.ts52.10%12.50%12.50%58.25%100–108, 108–118, 122, 130–139, 55, 67, 69, 76, 76, 78–79, 79, 83, 85–86, 92–98
   PatternBrush.ts73.91%87.50%100%69.64%21, 25–31, 34, 36, 44, 54, 62, 64–67, 69
   PencilBrush.ts77.16%82.35%100%74.44%116, 122, 124, 129, 139, 147–149, 151–152, 152, 155, 158, 169, 176, 176, 181–184, 189, 191, 193–194, 198–201, 205, 215, 224–231, 235–236, 238, 246, 248, 255–256, 260–263, 266, 276, 278, 280–288, 296–297, 299, 68, 84
   SprayBrush.ts51.67%0%0%58.86%100, 107, 107, 107, 107, 107–112, 118–120, 122, 128–135, 137–139, 141, 141, 141–148, 148, 152, 157, 162, 164, 169–170, 172, 180, 182, 185, 187, 195, 198–200, 200, 200–207, 207, 207–210, 212, 22, 22, 67, 85–87, 94–99
   typedefs.ts100%100%100%100%
src/canvas
   Canvas.ts79.46%44.15%98.21%89.74%1012–1013, 1016, 1023, 1025, 1030, 1080–1085, 1138, 1141, 1145, 1152, 1155, 1218–1222, 1301, 1301–1305, 1329, 1329, 1332, 1402, 1413, 1418–1423, 1426–1427, 1429, 1433, 1435–1436, 1438–1440, 1444, 1447, 1482, 1489, 1491–1502, 1504–1507, 1507–1508, 1510–1511, 1515–1516, 1519–1520, 1523–1525, 1528, 330, 355, 371, 390, 445, 562–563, 565, 568–569, 571, 581, 584–585, 587, 612, 618, 676, 678, 696, 698, 700–701, 703–706, 764, 800–803, 806, 815, 841, 850, 860, 862, 864–868, 871–878, 896, 904, 946, 949, 952, 964, 964–971, 973, 983–986
   CanvasOptions.ts100%100%100%100%
   SelectableCanvas.ts85.35%54.46%100%94.30%1006, 1008–1009, 1026, 1035, 1103–1107, 1153–1154, 1156–1157, 1159, 1186, 1188–1189, 1189, 1191, 1233, 1235, 1237, 1253, 1255, 1259, 1262, 1283, 1286, 1329–1336, 1339, 1342, 1351–1352, 1356–1365, 1369, 1371–1372, 1378–1383, 1387, 340–342, 346, 376, 398, 476, 527, 529, 605, 610, 687, 715
   StaticCanvas.ts75.58%62.08%97.85%76.90%1001, 1007, 1010, 1012, 1014, 1022, 1024–1030, 1040, 1046–1052, 1054–1055, 1057–1078, 1085–1087, 1089, 1097, 1103, 1105, 1105–1106, 1106–1107, 1109, 1109–1114, 1127,

@asturur asturur merged commit a6374b4 into master Feb 15, 2025
22 checks passed
@asturur asturur deleted the missing-image-cachekey branch February 15, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Slow filters on mobile devices compared to version 4.0.0-rc.1
1 participant