Skip to content

refactor(): Remove custom triple click logic #10478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 29, 2025
Merged

Conversation

asturur
Copy link
Member

@asturur asturur commented Mar 29, 2025

Description

While working on #10434 i hit some bug and issues with select all and other things, i found about event.details (!!!) and so figured out i can trash the custom triple click code.

Now tripleclick gets fired on every object, but after a doubleclick.
Before was an Itext/textbox internal gimmick.

Text beahiour should be unchanged.

SelectAll, SelectLine, SelectWord now they all behave consistently they just act on the selection data, while the user action behave consistently as well by updating the visual selection

In Action

Copy link

codesandbox bot commented Mar 29, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Mar 29, 2025

Build Stats

file / KB (diff) bundled minified
fabric 923.987 (-0.254) 306.648 (-0.436)

@asturur
Copy link
Member Author

asturur commented Mar 29, 2025

Needs some test for the new logic, in jest.

Copy link
Contributor

Coverage after merging remove-tripleclick-harness into master will be

85.50%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
fabric.ts86.92%20%0%95.79%10, 144, 144, 144, 144, 144, 190, 190, 190, 190, 190, 31, 33, 33, 33, 33, 33–34, 34, 34, 34, 34, 39, 8
index.node.ts14.29%100%0%25%23, 26, 29, 41, 44, 47
extensions/aligning_guidelines/util
   basic.ts100%100%100%100%
extensions/data_updaters/origins
   index.ts97.50%75%100%100%22–23
src
   ClassRegistry.ts92.54%69.23%100%97.92%35, 56
   Collection.ts75.29%42.31%51.61%84.67%130, 153, 155–157, 159, 167, 169–170, 181, 197, 217, 228, 241, 243, 245, 252, 254, 263, 265, 270, 279, 281, 286–287, 302, 304, 306, 309–310, 327–328, 328–329, 333–334, 337–338, 338–344, 346–348, 350, 75, 99
   CommonMethods.ts89.86%69.23%83.33%96%50, 52, 9
   EventTypeDefs.ts100%100%100%100%
   Intersection.ts82.32%43.18%73.33%96.14%105, 132–133, 166, 184–190, 228, 228, 237, 239, 289–291, 297, 297, 78, 80
   Observable.ts74.59%51.35%31.25%86.36%144, 153, 156, 168, 170, 172, 175, 41, 43, 68–70, 72, 76, 78, 80, 82–85, 87–91
   Point.ts84.95%62%44.12%92.68%104, 117, 148, 157, 179, 197, 206, 216, 225, 236–239, 259, 284–285, 294–297, 328, 341, 349, 359, 95
   Shadow.ts81.93%15%37.50%90%139, 139–140, 140–141, 143, 145–150, 159, 176, 176, 176, 194, 196–197, 199, 206, 206, 223–230, 232, 232, 234–235
   cache.ts86.75%62.50%75%90.14%57, 59, 71–72, 74–77
   config.ts82.63%20%44.44%94.20%127, 135–136, 138–141, 143, 146–147, 151, 156, 156, 156, 156, 156, 156
   constants.ts100%100%100%100%
   typedefs.ts100%100%100%100%
src/LayoutManager
   ActiveSelectionLayoutManager.ts85%69.23%28.57%100%43
   LayoutManager.ts90.38%69.62%53.85%99.31%279, 344, 355
   constants.ts100%100%100%100%
   index.ts48.57%37.50%80%66.67%1, 1, 1–2, 2, 2–3, 3, 3–4, 4, 4–5, 5, 5, 5–6
   types.ts100%100%100%100%
src/LayoutManager/LayoutStrategies
   ClipPathLayout.ts72%40%100%78.95%39, 41–44, 46–48, 54, 57–58, 66–69
   FitContentLayout.ts100%100%100%100%
   FixedLayout.ts85.71%20%100%100%23, 23
   LayoutStrategy.ts88.98%64%71.43%97.67%54, 73, 75, 88
   utils.ts62.90%7.14%100%78.72%28–32, 34–35, 39, 39–44, 47, 47, 47
src/Pattern
   Pattern.ts52.30%2.94%10%63.08%105–107, 113, 113–114, 117, 117–119, 119, 119–122, 130–132, 132, 132, 132, 132, 132–138, 140–141, 143, 150, 150, 150, 150, 153–160, 160, 160–164, 174–175, 175, 175, 175–176, 176, 176–182, 182, 182, 182–183, 183, 183–188, 190–199, 203–206, 209–210, 212–214, 216–218, 218, 218–221, 33, 37
   index.ts50%100%100%50%2
   types.ts100%100%100%100%
src/brushes
   BaseBrush.ts79.19%9.09%14.29%88.55%110, 114, 114–115, 122, 122, 122, 124–125, 130, 135, 143, 146, 155, 155, 155, 155, 155–160, 99
   CircleBrush.ts52.54%14.29%12.50%58.25%100–108, 108–118, 122, 130–139, 55, 67, 69, 76, 76, 78–79, 79, 83, 85–86, 92–98
   PatternBrush.ts44.12%0%0%53.57%21, 25–34, 36, 43, 43–44, 51–53, 53, 53–54, 60–64, 64, 64–69
   PencilBrush.ts42.18%0%0%52.02%103, 116, 122, 124, 129, 138–139, 146, 146–147, 147, 147–152, 152, 152, 152, 155–158, 167–169, 176, 176, 176, 176–177, 181–185, 185, 185, 185, 188–205, 215, 224–232, 235–238, 244, 244–257, 257–266, 274–276, 276–280, 280–299, 54, 54, 68, 71, 71, 71–72, 75, 84, 87, 87–88, 88, 88, 91, 91, 91–92, 92
   SprayBrush.ts52.25%0%0%58.86%100, 107, 107, 107, 107–112, 118–120, 122, 128–135, 137–139, 141, 141, 141–148, 148, 152, 157, 162, 164, 169–170, 172, 180, 182, 185, 187, 195, 198–200, 200, 200–207, 207, 207–210, 212, 22, 67, 85–87, 94–99
   typedefs.ts100%100%100%100%
src/canvas
   Canvas.ts76.19%36.88%87.50%86.12%1001–1005, 1029, 1031–1034, 1037, 1039, 1042, 1046, 1050–1051, 1056, 1095, 1095, 1100, 1102–1107, 1116, 1141–1142, 1160, 1163, 1165, 1167, 1172, 1174, 1177, 124, 1240–1244, 1278, 1286, 1323–1327, 1348, 1354, 1365, 1370–1371, 1371, 1375, 1375, 1381, 1417–1434, 1436–1437, 1437–1453, 1455, 1457–1458, 1460–1462, 1466, 1468, 1470–1472, 1475–1480, 1483–1485, 1488, 1490, 1504, 1511, 1513–1524, 1526, 1526–1529, 1529–1530, 1532–1533, 1537, 1537–1538, 1540–1542, 1545–1547, 1550, 1

@asturur asturur merged commit 1988404 into master Mar 29, 2025
21 of 22 checks passed
@asturur asturur deleted the remove-tripleclick-harness branch March 29, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant