Skip to content

Remove now dead argument from resolveClassComponentProps #33682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

kassens
Copy link
Member

@kassens kassens commented Jul 1, 2025

No longer used after #33648

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 1, 2025
@react-sizebot
Copy link

Comparing: 602917c...58c58a6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.50 kB = 93.67 kB 93.66 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.61 kB = 114.79 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 672.93 kB 672.89 kB = 118.42 kB 118.41 kB
facebook-www/ReactDOM-prod.modern.js = 663.36 kB 663.31 kB = 116.78 kB 116.77 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 58c58a6

@hnrkDEV
Copy link

hnrkDEV commented Jul 2, 2025

Great cleanup! Removing dead arguments helps keep the codebase clean and maintainable.
Just to confirm, was this argument completely unused everywhere?
Also, did you run all tests to ensure nothing else is affected by this removal?
Thanks for improving the code quality!

@kassens kassens merged commit 73aa744 into facebook:main Jul 2, 2025
247 checks passed
@kassens kassens deleted the pr33682 branch July 2, 2025 14:45
github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants