[PATCH] GPU (OpenBSD): fix pci.ids file location

[kevlo]

patch-src_detection_gpu_gpu_pci_c.txt

The attached patch fixes pci.ids file location.

I created the fastfetch port for OpenBSD, please update the README.md to include the OpenBSD installation method: "pkg_add fastfetch"
Thanks.

[CarterLi]

Thanks for your interests.

pkg_add fastfetch

I tried it in VM and it said Can't find fastfetch. Not sure if I missed something.

[kevlo]

Thanks for your interests.

pkg_add fastfetch

I tried it in VM and it said Can't find fastfetch. Not sure if I missed something.

You need to install the snapshot https://ftp.openbsd.org/pub/OpenBSD/snapshots/amd64/

[CarterLi]

Some comments of the Makefile you made for fastfetch:

1. Build dependency x11/xfce4/xfconf should be added. It's used for detecting xfce related configs. AFAIK although OpenBSD uses fvwm by default, but it allows users install other DEs.
2. CMake config -DSET_TWEAK=OFF should be set for release build.
3. I wonder why devel/dconf and devel/glib2 were set as Runtime dependencies

[CarterLi]

As for lang/python/3, it's used for shell completion (bash, zsh and fish). If python is missing, shell completion will be disabled but everything still work as normal. Because OpenBSD uses ksh by default, I prefer not to make python a hard dependency.

Note python is still used in CMake script for other things. It should still be left as a build dependency.

[kevlo]

Some comments of the Makefile you made for fastfetch:

1. Build dependency `x11/xfce4/xfconf` should be added. It's used for detecting `xfce` related configs. AFAIK although OpenBSD uses fvwm by default, but it allows users install other DEs.

2. CMake config `-DSET_TWEAK=OFF` should be set for release build.

Thanks for pointing that out, will do next time.

3. I wonder why `devel/dconf` and `devel/glib2` were set as `Runtime dependencies`

See https://man.openbsd.org/port-modules#CORE_MODULES_DOCUMENTATION

[CarterLi]

See https://man.openbsd.org/port-modules#CORE_MODULES_DOCUMENTATION

I don't think it has anything to do with fastfetch. fastfetch loads dependencies dynamically with dlopen, as long as the dependency source headers can be found when compiling. So everything should only be in Build dependencies. We don't force users to install anything they don't need.

See #1712

This module is used by ports installing gsettings schemas under ${PREFIX}/share/glib-2.0/schemas/.

We don't install gsettings schemas. We read them.

devel/glib2 doesn't even exist in CORE MODULES.

[CarterLi]

You need to install the snapshot https://ftp.openbsd.org/pub/OpenBSD/snapshots/amd64/

Tested and it works. Thanks.

[kevlo]

You need to install the snapshot https://ftp.openbsd.org/pub/OpenBSD/snapshots/amd64/

Tested and it works. Thanks.

Nice. Would you update README.md? Thanks.

[CarterLi]

Done @kevlo

[kevlo]

Thank you @CarterLi ^_^