Improve error message for invalid locations #6428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an invalid location is used when creating the `FirebaseVertexAI` object, all requests will fail. The error returned is 404 and HTML content. The message as-is is not easy to read. The new messaging points to the most likely reason for the 404 (invalid location).
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-vertexai### {{firebase_vertexai}} version 16.0.2 {: #vertex-ai_v16-0-2}
* {{fixed}} Improved error message when using an invalid location. GitHub [#6428](//github.com/firebase/firebase-android-sdk/issues/6428){: .external}
* {{fixed}} Fixed issue where Firebase App Check error tokens were unintentionally missing from the requests. GitHub [#6409](//github.com/firebase/firebase-android-sdk/issues/6409){: .external}
* {{fixed}} Clarified in the documentation that `Schema.integer` and `Schema.float` only provide hints to the model. GitHub [#6420](//github.com/firebase/firebase-android-sdk/issues/6420){: .external}
|
Vertex AI Mock Responses Check
|
Test Results 20 files - 1 002 20 suites - 1 002 14s ⏱️ - 35m 48s Results for commit 9a1c9b1. ± Comparison against base commit 442bab2. This pull request removes 5698 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
daymxn
approved these changes
Nov 5, 2024
|
cc @andrewheard |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid location is used when creating the
FirebaseVertexAIobject, all requests will fail. The error returned is 404 and HTML
content. The message as-is is not easy to read.
The new messaging points to the most likely reason for the
404 (invalid location).