Skip to content

Implement MultiDB Support and Tests #10465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 24, 2022
Merged

Implement MultiDB Support and Tests #10465

merged 12 commits into from
Nov 24, 2022

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Nov 7, 2022

No description provided.

@google-oss-bot
Copy link

google-oss-bot commented Nov 7, 2022

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (0dd5b06)Merge (81816c3)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4qPQAdeaIE.html

@mortenbekditlevsen
Copy link
Contributor

Wow! This is a dream come true! 🥰

@google-oss-bot
Copy link

google-oss-bot commented Nov 7, 2022

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.26% (7196035) to 88.28% (59cf567) by +0.03%.

    FilenameBase (7196035)Merge (59cf567)Diff
    FIRFirestore.mm87.87%89.56%+1.69%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TmZZlKqpjF.html

@tom-andersen tom-andersen marked this pull request as ready for review November 8, 2022 15:00
@tom-andersen tom-andersen changed the base branch from master to multidb November 16, 2022 17:05
@tom-andersen tom-andersen requested a review from wu-hui November 16, 2022 17:05
@tom-andersen tom-andersen changed the base branch from multidb to master November 21, 2022 16:28
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we also run a sanity Swift test to see if the API is as expected in Swift. You might not be able to do this because the API from obj-c is not exposed..

Please add a TODO for yourself to add swift test, before we actually release it in the future.

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Nov 22, 2022
@tom-andersen tom-andersen merged commit 68628ef into master Nov 24, 2022
@tom-andersen tom-andersen deleted the tomandersen/multiDb branch November 24, 2022 15:52
@firebase firebase locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants