Skip to content

[Vertex AI] Make GenerationConfig properties internal #13904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 17, 2024

Made the GenerationConfig properties internal to align with the Android SDK (access levels were already aligned in all other files). Updated the documentation and moved it into the parameters since the properties are no longer public (DocC links will not work). This PDF of the generated DocC may be easier to read.

@andrewheard andrewheard marked this pull request as ready for review October 17, 2024 02:19
@andrewheard andrewheard requested a review from paulb777 October 17, 2024 02:19
@andrewheard
Copy link
Contributor Author

cc: @rachelsaunders We may want to add some of the new configuration options to https://firebase.google.com/docs/vertex-ai/model-parameters eventually and link there instead. It could be difficult to keep details about supported model versions in sync with the Cloud docs for GenerationConfig though so we may want to link there regardless.

@rachelsaunders
Copy link
Contributor

cc: @rachelsaunders We may want to add some of the new configuration options to https://firebase.google.com/docs/vertex-ai/model-parameters eventually and link there instead. It could be difficult to keep details about supported model versions in sync with the Cloud docs for GenerationConfig though so we may want to link there regardless.

This is content that we're looking at sharing directly between the docsets in the backend. For now, it's fine to link over to the Cloud docs till that happens :-)

@andrewheard andrewheard merged commit 8328630 into main Oct 17, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-public-properties branch October 17, 2024 14:09
@firebase firebase locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants