Skip to content

Conversation

YashKale313
Copy link
Contributor

Added DD-MM-YYYY format option button in configuration menu.

@mmahmoudian
Copy link
Member

Thanks. Since your proposal was to have even number of options, would you please also add the century (or something similar).

@YashKale313
Copy link
Contributor Author

@mmahmoudian Actually the logic that add format buttons ensures that there are even number of formats passed. So before threre were 21 formats (including century) and it was only adding 20 formats excluding century but now since i added 1 it has become 22 formats and its showing all 22 as its even.

@YashKale313
Copy link
Contributor Author

YashKale313 commented Sep 5, 2024

@mmahmoudian Here are the code snippets for your refrence

For adding formats-
image

For adding buttons-
image

let me know if you feels anything wrong here.

@YashKale313
Copy link
Contributor Author

Hi @mmahmoudian Just checking in if you have reviewd the PR and can it be merged.

@b0ch3nski
Copy link
Contributor

I've build with this patch (it applied clearly) and indeed the new option is available in the config UI

@borgmanJeremy
Copy link
Collaborator

I no longer have a Windows machine to test on. Does anyone know if this format is compatible on Windows or if it needs to move to an ifdef block?

@ElTh0r0
Copy link
Contributor

ElTh0r0 commented Jun 22, 2025

I no longer have a Windows machine to test on. Does anyone know if this format is compatible on Windows or if it needs to move to an ifdef block?

No ifdef block required for this PR! It adds another numeric date format, which means there is no issue with potential special characters (but I tested if on Windows anyway). IMO this PR can be merged.

Thanks. Since your proposal was to have even number of options, would you please also add the century (or something similar).

I created PR #4033, which makes the button layout creation independent of even/odd number of items in the list, so we won't have to take care about this constraint in future once #4033 is merged.

@mmahmoudian
Copy link
Member

@borgmanJeremy shall I add this to v13 milestone?

@borgmanJeremy borgmanJeremy merged commit 89679f5 into flameshot-org:master Jun 22, 2025
1 check passed
@mmahmoudian mmahmoudian added this to the v13 milestone Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants