-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added DD-MM-YYYY format option button in configuration menu. #3710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks. Since your proposal was to have even number of options, would you please also add the century (or something similar). |
@mmahmoudian Actually the logic that add format buttons ensures that there are even number of formats passed. So before threre were 21 formats (including century) and it was only adding 20 formats excluding century but now since i added 1 it has become 22 formats and its showing all 22 as its even. |
@mmahmoudian Here are the code snippets for your refrence let me know if you feels anything wrong here. |
Hi @mmahmoudian Just checking in if you have reviewd the PR and can it be merged. |
I've build with this patch (it applied clearly) and indeed the new option is available in the config UI |
I no longer have a Windows machine to test on. Does anyone know if this format is compatible on Windows or if it needs to move to an ifdef block? |
No
I created PR #4033, which makes the button layout creation independent of even/odd number of items in the list, so we won't have to take care about this constraint in future once #4033 is merged. |
@borgmanJeremy shall I add this to v13 milestone? |
Added DD-MM-YYYY format option button in configuration menu.