fix linting errors for flathub #4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes linting errors for Flathub submission by addressing network restrictions during builds. The main changes accommodate Flathub's requirement that dependencies be pre-fetched rather than downloaded during the build process.
- Modifies Flatpak manifest to fetch dependencies as separate sources rather than relying on network access during build
- Updates CMake configuration to support both local and remote dependency fetching
- Adjusts Flatpak permissions for better security compliance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packaging/flatpak/org.flameshot.Flameshot.yml | Updates Flatpak manifest to pre-fetch dependencies and adjust permissions |
| CMakeLists.txt | Adds conditional logic to use local dependencies when available, falling back to FetchContent |
fixed typo Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the linting errors encountered when pushing v13 to flathub. One of the main issues was flathub does not allow network calls during the build so the dependencies must be fetched and CMake must accomodate both options.