Allow string for copy sources, query destination, and default dataset #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a few more cases where it was required to create a TableReference or DatasetReference. * Allow a string for destination in QueryJobConfig . * Allow a string for default_dataset in QueryJobConfig . * Allow a list of strings for sources in Client.copy_table.
|
CC @lbristol88 |
alixhami
requested changes
Mar 26, 2019
Rename the helper to `_table_arg_to_table_ref` and always return a TableReference when something sensible is passed in. Add a second helper `_table_arg_to_table` that always returns a `Table`, which is needed in `list_rows` and `insert_rows` because only a `Table` contains a schema.
alixhami
reviewed
Mar 27, 2019
alixhami
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a few more cases where it was required to create a
TableReferenceorDatasetReference.destinationinQueryJobConfig.default_datasetinQueryJobConfig.sourcesinClient.copy_table.Closes #7558