Initial generation of Phishing Protection. #7801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
suggested changes
Apr 29, 2019
|
Unfortunately it's not currently possible to rename the client upstream. Ruby also renamed the client using synth.
|
tseaver
suggested changes
Apr 30, 2019
phishingprotection/synth.py
Outdated
| unit_test = Path("tests/unit/gapic/v1beta1/test_phishing_protection_service_v1_beta1_client_v1beta1.py") | ||
|
|
||
| files = [client, client_config, transport, unit_test] | ||
| for f in files: |
There was a problem hiding this comment.
I'm surprised flake8 isn't complaining about one-character variable name here. Even if we do change it to f, we need to change how it is used inside the loop, too.
There was a problem hiding this comment.
Eek, sorry about that. I don't think synth.py is currently checked by flake or black.
tseaver
reviewed
Apr 30, 2019
tseaver
approved these changes
Apr 30, 2019
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clients were generated with the version name in the name of the clients, so the synth script does a lot of renaming.