Fix: adjusting retry logic to avoid retrying successful job creation #1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniewang526
suggested changes
Mar 2, 2022
stephaniewang526
approved these changes
Mar 3, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
🤖 I have created a release *beep* *boop* --- ### [2.9.1](v2.9.0...v2.9.1) (2022-03-03) ### Bug Fixes * adjusting retry logic to avoid retrying successful job creation ([#1879](#1879)) ([fd07533](fd07533)) * **java:** add additional configurations to fix native image tests ([#1859](#1859)) ([3e82960](3e82960)) ### Documentation * **sample:** Table exists sample fix ([#1868](#1868)) ([698306e](698306e)) ### Dependencies * update dependency com.google.apis:google-api-services-bigquery to v2-rev20220220-1.32.1 ([#1872](#1872)) ([e67cf65](e67cf65)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.8.0 ([#1876](#1876)) ([a16985f](a16985f)) * update dependency com.google.cloud:google-cloud-storage to v2.4.2 ([#1853](#1853)) ([ef91109](ef91109)) * update dependency com.google.cloud:google-cloud-storage to v2.4.4 ([#1873](#1873)) ([a4deb16](a4deb16)) * update dependency com.google.cloud:native-image-support to v0.12.4 ([#1855](#1855)) ([376738d](376738d)) * update dependency com.google.cloud:native-image-support to v0.12.5 ([#1874](#1874)) ([c68c49a](c68c49a)) * update dependency com.google.cloud:native-image-support to v0.12.6 ([#1878](#1878)) ([3749921](3749921)) * update dependency com.google.code.gson:gson to v2.9.0 ([#1850](#1850)) ([627da62](627da62)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.10 ([#1860](#1860)) ([b31b44c](b31b44c)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.10 ([#1861](#1861)) ([ae05dfe](ae05dfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1744 introduced retrying 200 responses, but the regex that we are using is too broad: [".*exceed.*rate.limit."] and in some cases it may catch a valid response.
The issue is that the current logic is scanning the whole response. In this PR the retry logic is modified to specifically check the error message from the response. For this purpose parsing logic was developed to extract error messages from responses. This logic is specifically designed for the jobs.insert method response (only case observed so far where a response with status code 200 might also return an error message).