Skip to content

feat: add Lineage metrics for CloudBigtableIO #4438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

ad548
Copy link
Member

@ad548 ad548 commented Sep 4, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@ad548 ad548 requested a review from a team as a code owner September 4, 2024 15:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Sep 4, 2024
@ad548 ad548 changed the title Add Lineage metrics for CloudBigtableIO feat: add Lineage metrics for CloudBigtableIO Sep 4, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 30, 2024
@ad548 ad548 force-pushed the adas-lineage branch 2 times, most recently from 24012e1 to ce85893 Compare November 1, 2024 16:49
@ad548 ad548 marked this pull request as draft November 1, 2024 17:22
@ad548 ad548 force-pushed the adas-lineage branch 13 times, most recently from 8d18829 to 0719214 Compare November 5, 2024 19:07
@ad548 ad548 force-pushed the adas-lineage branch 4 times, most recently from ebc53bc to 864e1f7 Compare November 5, 2024 23:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 3, 2025
@ad548 ad548 force-pushed the adas-lineage branch 2 times, most recently from a47230a to 43ece0b Compare March 4, 2025 15:05
@ad548 ad548 marked this pull request as ready for review March 4, 2025 15:32
@ad548 ad548 force-pushed the adas-lineage branch 4 times, most recently from 9fc1cdf to 1feea67 Compare March 4, 2025 19:27
@andre-sampaio andre-sampaio self-assigned this Mar 6, 2025
@andre-sampaio andre-sampaio added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2025
@andre-sampaio
Copy link
Contributor

@andre-sampaio
Copy link
Contributor

IIUC this would break existing workloads for projects without the lineage API enabled, is this correct?

If so we need to provide this as an option (probably defaulted to false). It might still be a good idea to have this behind a flag anyway

@ad548
Copy link
Member Author

ad548 commented Mar 6, 2025

Can you also add some brief documentation to https://github.com/googleapis/java-bigtable-hbase/blob/main/bigtable-dataflow-parent/bigtable-beam-import/README.md?

That's a good idea! I added some documentation.

@ad548
Copy link
Member Author

ad548 commented Mar 6, 2025

IIUC this would break existing workloads for projects without the lineage API enabled, is this correct?

If so we need to provide this as an option (probably defaulted to false). It might still be a good idea to have this behind a flag anyway

Good question. So this feature is implemented using Beam metrics that are always emitted by Beam (alongside any number of other metrics) and sent over to Dataflow backend. If lineage is not enabled Dataflow drops those metrics in backend. So it should be fine to always report these. Other systems/IOs are doing a similar thing.

@andre-sampaio
Copy link
Contributor

IIUC this would break existing workloads for projects without the lineage API enabled, is this correct?
If so we need to provide this as an option (probably defaulted to false). It might still be a good idea to have this behind a flag anyway

Good question. So this feature is implemented using Beam metrics that are always emitted by Beam (alongside any number of other metrics) and sent over to Dataflow backend. If lineage is not enabled Dataflow drops those metrics in backend. So it should be fine to always report these. Other systems/IOs are doing a similar thing.

Ahhh got it, thank you for explaining! lgtm

@andre-sampaio andre-sampaio added the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0a68ad8 into googleapis:main Mar 6, 2025
11 of 12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants