-
Notifications
You must be signed in to change notification settings - Fork 180
feat: add Lineage metrics for CloudBigtableIO #4438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
24012e1
to
ce85893
Compare
8d18829
to
0719214
Compare
...igtable-beam-import/src/test/java/com/google/cloud/bigtable/beam/it/CloudBigtableBeamIT.java
Outdated
Show resolved
Hide resolved
ebc53bc
to
864e1f7
Compare
a47230a
to
43ece0b
Compare
9fc1cdf
to
1feea67
Compare
...parent/bigtable-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableIO.java
Show resolved
Hide resolved
...parent/bigtable-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableIO.java
Show resolved
Hide resolved
Can you also add some brief documentation to https://github.com/googleapis/java-bigtable-hbase/blob/main/bigtable-dataflow-parent/bigtable-beam-import/README.md? |
IIUC this would break existing workloads for projects without the lineage API enabled, is this correct? If so we need to provide this as an option (probably defaulted to |
...parent/bigtable-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableIO.java
Show resolved
Hide resolved
That's a good idea! I added some documentation. |
Good question. So this feature is implemented using Beam metrics that are always emitted by Beam (alongside any number of other metrics) and sent over to Dataflow backend. If lineage is not enabled Dataflow drops those metrics in backend. So it should be fine to always report these. Other systems/IOs are doing a similar thing. |
Ahhh got it, thank you for explaining! lgtm |
0a68ad8
into
googleapis:main
🤖 I have created a release *beep* *boop* --- ## [2.15.0](https://togithub.com/googleapis/java-bigtable-hbase/compare/v2.14.8...v2.15.0) (2025-03-06) ### Features * add Lineage metrics for CloudBigtableIO ([#4438](https://togithub.com/googleapis/java-bigtable-hbase/issues/4438)) ([0a68ad8](https://togithub.com/googleapis/java-bigtable-hbase/commit/0a68ad873a22a74c3982c32fd3971c6102db07c8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.