Skip to content

deps: upgrade java-bigtable to 2.49.0 and fix tests #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 5, 2024
Merged

deps: upgrade java-bigtable to 2.49.0 and fix tests #4462

merged 5 commits into from
Dec 5, 2024

Conversation

igorbernstein2
Copy link
Collaborator

@igorbernstein2 igorbernstein2 commented Dec 4, 2024 •
edited
Loading

  • upgrade java-bigtable to 2.49.0
  • update metrics integration to respect trailer skipping
  • stop running unit tests as part of integration tests, they are run separately in parallel
  • use BigtableDataClientFactory for cached connections instead of duplicating the logic
  • update unit tests to target a fake bigtable service instead of sending invalid resource ids to actual bigtable service
  • fix cached connection keys for tests
  • fix channel pool settings for emulator
  • clean up some overly verbose test log output

@igorbernstein2
deps: upgrade java-bigtable to 2.49.0
0202644 
Change-Id: I801be8a764c212d7922634de61b41afaa3f2c3b6
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner December 4, 2024 02:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Dec 4, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: xs Pull request size is extra small. and removed api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: xs Pull request size is extra small. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2
update metrics test to skipping trailers behavior
679e5fb 
Change-Id: Ib7f1e7d87b2ef177d6fba69f0d139f5291c3d38c
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Dec 4, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2
a bit more cleanup
3502cde 
Change-Id: I23ef04f8ea555e2b6d2c53aa8b98a331c71960ae
@igorbernstein2
more cleanup
f007f04 
Change-Id: I002a750839ee0b324121c2098f93fbcd5385728b
@igorbernstein2 igorbernstein2 changed the title deps: upgrade java-bigtable to 2.49.0 deps: upgrade java-bigtable to 2.49.0 and fix tests Dec 4, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2
try to fix test flakiness
29a4a9b 
Change-Id: Iebf9d10d8194e7f0b2c85ee5e530aa84e6a3a895
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2024
@igorbernstein2 igorbernstein2 merged commit 5cda5b1 into googleapis:main Dec 5, 2024
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 5, 2024
@igorbernstein2 igorbernstein2 deleted the update-bt branch December 5, 2024 00:29
@release-please release-please bot mentioned this pull request Dec 5, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 5, 2024
@release-please
chore(main): release 2.14.8 (#4464)
6f51c3f 
🤖 I have created a release *beep* *boop*
---


## [2.14.8](https://togithub.com/googleapis/java-bigtable-hbase/compare/v2.14.7...v2.14.8) (2024-12-05)


### Dependencies

* upgrade java-bigtable to 2.49.0 and fix tests ([#4462](https://togithub.com/googleapis/java-bigtable-hbase/issues/4462)) ([5cda5b1](https://togithub.com/googleapis/java-bigtable-hbase/commit/5cda5b1f0288b8984d913c86bb00476502313217))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorbernstein2 @mutianf @yoshi-kokoro